Update EntitySchema diff marker generation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Jan 20 2021, 2:31 PM

Description

MediaWiki changed the way it generates diff markers (“+”, “-”) with T192526: Diff-view: indicators should not be copied on copy-and-paste (compare EntitySchema test update). We should update the markers EntitySchema generates itself accordingly.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update diff marker generation	mediawiki/extensions/EntitySchema	master	+11 -12

Customize query in gerrit

Related Objects

Mentioned In: T272579: Update Wikibase diff marker generation
Mentioned Here: T192526: Diff-view: indicators should not be copied on copy-and-paste

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 20 2021, 2:31 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 20 2021, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 657347 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/EntitySchema@master] Update diff marker generation

https://gerrit.wikimedia.org/r/657347

gerritbot added a project: Patch-For-Review.Jan 20 2021, 2:36 PM

This turns out to be very straightforward, we don’t need our own CSS or anything.

Change 657347 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Update diff marker generation

https://gerrit.wikimedia.org/r/657347

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 5:10 PM

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 20 2021, 5:11 PM

Lucas_Werkmeister_WMDE claimed this task.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 6:00 PM

Lucas_Werkmeister_WMDE mentioned this in T272579: Update Wikibase diff marker generation.Jan 21 2021, 10:30 AM