Page MenuHomePhabricator

LTR doesn't work on Hebrew pages
Closed, ResolvedPublic

Description

Author: shayde

Description:
In hebrew pages of http://he.wikipedia.org, the text is
normally aligned to the right. However, English text should
be aligned to the left. The alignment was done using "DIV
dir=ltr" HTML tag, but ut stopped working.


Version: unspecified
Severity: normal
OS: Windows XP
Platform: PC
URL: http://he.wikipedia.org

Details

Reference
bz725

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 7:00 PM
bzimport set Reference to bz725.
bzimport added a subscriber: Unknown Object (MLST).

There isn't a significant amount of English text visible there now.
Is this still a problem?
Can you provide a sample page?
Under which browsers and operating systems does the problem appear?
What exactly is the problem, with a comparison between expected and actual output?

Ganglieri provided a test case at http://yi.wikipedia.org/wiki/User:Danny/todos

The problem was this part of skins/monobook/rtl.css:
body,
body * {

direction: rtl;

/* unicode-bidi: bidi-override;*/

unicode-bidi: embed;

}

By CSS2's rules, the bits under the 'body *' selector actually override an explicit dir="ltr"
attribute on any element in the body. Letting the value just inherit from body should work fine
(tested briefly in Safari 1.3, Firefox 1.0.3, and IE 6.0 on XP SP2).

Committed to CVS HEAD and REL1_4 and installed live.