Maniphest T272511

Drop default of oldimage.oi_timestamp
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Jan 20 2021, 5:08 PM

Tags

Referenced Files

None

Subscribers

Related Objects

Mentioned Here: T42626: Standardise type of timestamp database fields (MySQL)
T230428: Migrate tables.sql to abstract schema

Event Timeline

Ladsgroup created this task.Jan 20 2021, 5:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2021, 5:08 PM

Ladsgroup updated the task description. (Show Details)Jan 20 2021, 5:10 PM

Marostegui triaged this task as Medium priority.Jan 21 2021, 6:40 AM

Marostegui claimed this task.Feb 26 2021, 6:02 AM

Marostegui added a project: DBA.

Marostegui moved this task from Triage to Ready on the DBA board.

@Ladsgroup is the schema change needed only: ALTER TABLE oldimage ALTER oi_timestamp DROP DEFAULT;? I am seeing: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/656586/2/maintenance/archives/patch-oldimage-oi_name-varbinary.sql and it also includes: ALTER TABLE /*_*/oldimage MODIFY oi_name VARBINARY(255) DEFAULT '' NOT NULL, MODIFY oi_archive_name VARBINARY(255) DEFAULT '' NOT NULL;

I have checked a few wikis and we already have varbinary there, so I guess that's why you skipped it on this task, but just wanted to confirm that is the case.
Thanks

The second one is for non-binary fields (you'd see it's as varchar in wikitech) and it's not needed for our production.

Thanks for the clarification!

Marostegui updated the task description. (Show Details)Feb 26 2021, 9:44 AM

Marostegui updated the task description. (Show Details)Feb 26 2021, 12:48 PM

Altered db1096:3316 and db1098:3316 in eqiad, if nothing breaks during the next few days I will proceed

Marostegui updated the task description. (Show Details)Mar 1 2021, 1:48 PM

Marostegui moved this task from Ready to In progress on the DBA board.Mar 1 2021, 7:53 PM

Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.

Marostegui updated the task description. (Show Details)Mar 2 2021, 1:08 PM

Marostegui updated the task description. (Show Details)Mar 2 2021, 1:31 PM

Marostegui updated the task description. (Show Details)Mar 3 2021, 5:46 AM

Marostegui updated the task description. (Show Details)Mar 3 2021, 5:51 AM

Marostegui updated the task description. (Show Details)Mar 3 2021, 5:54 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Mar 3 2021, 6:07 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Mar 3 2021, 6:14 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Mar 3 2021, 6:18 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Mar 3 2021, 6:24 AM

Marostegui updated the task description. (Show Details)Mar 3 2021, 6:32 AM

Marostegui updated the task description. (Show Details)Mar 3 2021, 7:53 AM

The last pending host is db1123 (s3 master) which I will do tomorrow morning as it will take 15h to complete.

In T272511#6877940, @Marostegui wrote:

The last pending host is db1123 (s3 master) which I will do tomorrow morning as it will take 15h to complete.

This is now running

All done