Page MenuHomePhabricator

Drop default of oldimage.oi_timestamp
Closed, ResolvedPublic

Description

Part of T42626: Standardise type of timestamp database fields (MySQL) and T230428: Migrate tables.sql to abstract schema

  1. ALTERs to run: (From 656586) ALTER TABLE oldimage ALTER oi_timestamp DROP DEFAULT;
  2. Where to run those changes: all.dblist
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Tested in beta cluster.
  6. if the data should be made available on the labs replicas and/or dumps: Yes, data in this table is public.

Progress

Event Timeline

Marostegui triaged this task as Medium priority.Jan 21 2021, 6:40 AM
Marostegui added a project: DBA.
Marostegui moved this task from Triage to Ready on the DBA board.

@Ladsgroup is the schema change needed only: ALTER TABLE oldimage ALTER oi_timestamp DROP DEFAULT;? I am seeing: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/656586/2/maintenance/archives/patch-oldimage-oi_name-varbinary.sql and it also includes: ALTER TABLE /*_*/oldimage MODIFY oi_name VARBINARY(255) DEFAULT '' NOT NULL, MODIFY oi_archive_name VARBINARY(255) DEFAULT '' NOT NULL;

I have checked a few wikis and we already have varbinary there, so I guess that's why you skipped it on this task, but just wanted to confirm that is the case.
Thanks

The second one is for non-binary fields (you'd see it's as varchar in wikitech) and it's not needed for our production.

Altered db2089:3316 will leave it running for a few days

s6 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db2141
  • db2129
  • db2124
  • db2117
  • db2114
  • db2097
  • db2095
  • db2089
  • db2087
  • db2076
  • db1173
  • db1168
  • db1155
  • db1140
  • db1139
  • db1131
  • db1125
  • db1113
  • db1098
  • db1096
  • db1088
  • db1085
  • clouddb1019
  • clouddb1015

Altered db1096:3316 and db1098:3316 in eqiad, if nothing breaks during the next few days I will proceed

s5 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1154
  • db1150
  • db1145
  • db1144
  • db1130
  • db1124
  • db1113
  • db1110
  • db1100
  • db1096
  • db1082
  • clouddb1020
  • clouddb1016

s2 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1171
  • db1170
  • db1162 -> Host down (will be recloned from another host)
  • db1155
  • db1146
  • db1129
  • db1125
  • db1122
  • db1105
  • db1076
  • db1074
  • clouddb1018
  • clouddb1014
Marostegui updated the task description. (Show Details)
Marostegui updated the task description. (Show Details)

s4 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1160
  • db1155
  • db1150
  • db1149
  • db1148
  • db1147
  • db1146
  • db1145
  • db1144
  • db1143
  • db1142
  • db1141
  • db1138
  • db1125
  • db1121
  • clouddb1019
  • clouddb1015

s8 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1005
  • db1172
  • db1154
  • db1126
  • db1124
  • db1116
  • db1114
  • db1111
  • db1109
  • db1104
  • db1101
  • db1099
  • db1087
  • clouddb1020
  • clouddb1016

s7 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1174
  • db1170
  • db1155
  • db1136
  • db1127
  • db1125
  • db1116
  • db1101
  • db1098
  • db1086
  • db1079
  • clouddb1018
  • clouddb1014

s1 progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1003
  • db1169
  • db1164
  • db1163
  • db1154
  • db1140
  • db1139
  • db1135
  • db1134
  • db1133
  • db1124
  • db1119
  • db1118
  • db1106
  • db1105
  • db1099
  • db1084
  • db1083
  • clouddb1017
  • clouddb1013

s3 eqiad progress

  • labsdb1012
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1004
  • db1175
  • db1171
  • db1166
  • db1157
  • db1154
  • db1124
  • db1123
  • db1112
  • clouddb1017
  • clouddb1013

The last pending host is db1123 (s3 master) which I will do tomorrow morning as it will take 15h to complete.

The last pending host is db1123 (s3 master) which I will do tomorrow morning as it will take 15h to complete.

This is now running

Marostegui updated the task description. (Show Details)

All done