Page MenuHomePhabricator
Create Task
Maniphest T272518

Watch for extensions broken by WikiPage now deprecating construction on bad titles
Closed, ResolvedPublic
Actions

Description

  • FlaggedRevs
  • EntitySchema
  • DisplayTitle
  • AccessControl
  • LastModified
NOTE: this should stay open for a week or so after the last issue was fixed, in case a new issue is discovered.

Details

SubjectRepoBranchLines +/-
Don't make WikiPage calls with impossible page namesmediawiki/extensions/DisplayTitleREL1_35+6 -0
Don't make WikiPage calls with impossible page namesmediawiki/extensions/LastModifiedmaster+7 -1
Don't make WikiPage calls with impossible page namesmediawiki/extensions/AccessControlmaster+2 -2
Don't make WikiPage calls with impossible page namesmediawiki/extensions/DisplayTitlemaster+6 -0
tests: Fix WikiPage calls with impossible page namesmediawiki/extensions/EntitySchemamaster+4 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenBUG REPORTNoneT12863 Links on commons upload summaries do not link to commons
 OpenNoneT5498 Image history is confusing
 StalledNoneT96384 Integrate file revisions with description page history
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
 OpenNoneT135221 Make TimedText content an integral part of the File page
 OpenFeatureNoneT2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
 OpenNoneT132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenFeatureNoneT14963 allow per-page exceptions to spam blacklist
 OpenNoneT203157 Make the spam whitelist its own slot
 OpenFeatureNoneT56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
 StalledNoneT174043 Deploy Multi-Content Revisions
 OpenNoneT174022 Implement multi-content revisions
 OpendanielT196087 Refactored implementation of MCR page update interface
 OpenpmiazgaT302623 FY2022-2023: Improve Backend Pageview Timing
 ResolvedNoneT206498 MediaWiki needlessly queries page data twice on page views
 InvalidNoneT273514 MW expedition work [high effort]
 OpenNoneT273542 Migrate ZObjectStore from WikiPage to PageStore when it exists
 ResolvedNoneT195069 Factor PageStore and PageRecord out of WikiPage
 ResolveddanielT272421 Make WikiPage a PageRecord
 ResolveddanielT272424 Make WikiPage a ProperPageIdentity
 ResolveddanielT272518 Watch for extensions broken by WikiPage now deprecating construction on bad titles
 ResolvedJdforrester-WMFT272170 "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos
 ResolvedPRODUCTION ERRORUmherirrenderT273506 [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons
 ResolveddanielT274274 FileImporter constructs EditPage for a special page
 ResolveddanielT274276 LiquidThreads constructs Article on special page
 ResolveddanielT274317 CirrusSearch: access to WikiPage that not represents a page

Event Timeline

Jdforrester-WMF created this task.Jan 20 2021, 5:55 PM
Jdforrester-WMF added a subtask: T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.
daniel claimed this task.Jan 20 2021, 6:03 PM
daniel triaged this task as High priority.
daniel moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
gerritbot added a comment.Jan 20 2021, 6:05 PM

Change 657382 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/EntitySchema@master] tests: Fix WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/657382

gerritbot added a project: Patch-For-Review.Jan 20 2021, 6:05 PM
daniel changed the task status from Open to Stalled.Jan 20 2021, 6:10 PM
daniel moved this task from Doing to PageStore pile on the Platform Team Workboards (MW Expedition) board.
daniel added a project: MediaWiki-Core-Revision-backend.
daniel updated the task description. (Show Details)
gerritbot added a comment.Jan 20 2021, 6:17 PM

Change 657382 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] tests: Fix WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/657382

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 7:10 PM
daniel renamed this task from Fix code in extensions broken by WikiPage now deprecating construction on bad titles to Watch for extensions broken by WikiPage now deprecating construction on bad titles.Jan 22 2021, 9:03 AM
daniel moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
DannyS712 changed the task status from Stalled to Open.Jan 30 2021, 5:34 AM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)Jan 30 2021, 5:51 AM
Umherirrender added a project: ci-test-error.Jan 30 2021, 10:27 AM
gerritbot added a comment.Jan 30 2021, 3:49 PM

Change 660395 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/DisplayTitle@master] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/660395

gerritbot added a project: Patch-For-Review.Jan 30 2021, 3:49 PM
gerritbot added a comment.Jan 30 2021, 3:58 PM

Change 660400 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/AccessControl@master] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/660400

gerritbot added a comment.Jan 30 2021, 4:01 PM

Change 660395 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@master] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/660395

gerritbot added a comment.Jan 30 2021, 4:03 PM

Change 660401 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/LastModified@master] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/660401

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 4:04 PM
gerritbot added a comment.Jan 30 2021, 4:45 PM

Change 660400 merged by jenkins-bot:
[mediawiki/extensions/AccessControl@master] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/660400

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 4:53 PM
gerritbot added a comment.Jan 30 2021, 4:53 PM

Change 660401 merged by jenkins-bot:
[mediawiki/extensions/LastModified@master] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/660401

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2021, 5:10 PM
Jdforrester-WMF mentioned this in T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons.Feb 1 2021, 5:48 PM
Jdforrester-WMF added a subtask: T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons.
daniel lowered the priority of this task from High to Medium.Feb 3 2021, 5:44 PM
• Pchelolo closed this task as Resolved.Feb 23 2021, 9:01 PM
• Pchelolo closed subtask T274274: FileImporter constructs EditPage for a special page as Resolved.
• Pchelolo closed subtask T274317: CirrusSearch: access to WikiPage that not represents a page as Resolved.
• Pchelolo closed subtask T274276: LiquidThreads constructs Article on special page as Resolved.
• Pchelolo subscribed.

A number of trains has passed since initial deprecation and we've fixed all the instances that showed up in the logs. Please reopen if something was missed.

gerritbot added a comment.Mar 23 2021, 1:27 PM

Change 674331 had a related patch set uploaded (by Cicalese; owner: Jforrester):
[mediawiki/extensions/DisplayTitle@REL1_35] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/674331

gerritbot added a project: Patch-For-Review.Mar 23 2021, 1:27 PM
gerritbot added a comment.Mar 23 2021, 1:50 PM

Change 674331 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@REL1_35] Don't make WikiPage calls with impossible page names

https://gerrit.wikimedia.org/r/674331

CCicalese_WMF mentioned this in rEDPT667175698f57: Don't make WikiPage calls with impossible page names.Mar 23 2021, 1:53 PM
Umherirrender closed subtask T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons as Resolved.Apr 27 2021, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL