Implement private wiki read permission in a way that works with Authority
Open, HighPublic
Actions

Assigned To

None

Authored By

	daniel
	Jan 20 2021, 6:20 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

daniel

Description

Authority performs checks against PageIdentities, which will at some point no longer be able to represent SpecialPages. For nearly all permissions this works, but we still need a way to check the 'read' permission for special pages:

On private wikis, a few special pages are whitelisted, so they can be accessed without being logged in. Since these special pages cannot be represented as PageIdentities, we need another way to check them.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	EXPERIMENT: Define PageLocation	Daniel Kinzler	mediawiki/core	master	+353 -231
	EXPERIMENT: prohibit permission checks against special pages	Daniel Kinzler	mediawiki/core	master	+124 -48

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T218674 User::getRights() applies session rights restrictions to non-session users
Resolved	None	T180888 All permission checks should be able to return a custom error message
Open	None	T231930 Introduce Authority objects to represent the user performing a given action
Open	None	T272519 Implement private wiki read permission in a way that works with Authority

Event Timeline

daniel created this task.Jan 20 2021, 6:20 PM

daniel triaged this task as High priority.

daniel lowered the priority of this task from High to Medium.

daniel moved this task from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.

Change 657390 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] EXPERIMENT: prohibit permission checks against special pages

https://gerrit.wikimedia.org/r/657390

gerritbot added a project: Patch-For-Review.Jan 20 2021, 6:52 PM

Change 657400 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] EXPERIMENT: Define PageLocation

https://gerrit.wikimedia.org/r/657400

• Pchelolo assigned this task to daniel.Feb 23 2021, 6:05 PM

• Pchelolo raised the priority of this task from Medium to High.

daniel lowered the priority of this task from High to Medium.Feb 25 2021, 2:12 PM

daniel raised the priority of this task from Medium to High.Mar 10 2021, 6:24 PM

daniel moved this task from Authority pile to Doing on the Platform Team Workboards (MW Expedition) board.Mar 12 2021, 12:09 PM

thiemowmde mentioned this in rEFLI4f2a99ca9ec3: Use MockTitleTrait in ImportPlanValidatorTest.Mar 12 2021, 8:26 PM

daniel moved this task from Doing to Authority pile on the Platform Team Workboards (MW Expedition) board.May 24 2022, 8:12 AM

Aklapper edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Sep 17 2023, 3:53 PM

@daniel: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Change #657390 abandoned by Daniel Kinzler:

[mediawiki/core@master] EXPERIMENT: prohibit permission checks against special pages

https://gerrit.wikimedia.org/r/657390

Change #657400 abandoned by Daniel Kinzler:

[mediawiki/core@master] EXPERIMENT: Define PageLocation