Page MenuHomePhabricator
Create Task
Maniphest T272535

New Discussion Tool lets you post a discussion without a topic if you remove the topic name
Closed, InvalidPublic
Actions

Description

Steps to replicate:

  1. Open the New Discussion Tool
  2. Enter some text in the tool's Description field.
  3. Click the Add Topic button.
  4. At this point you will get the feedback message "Please provide a topic for your comment. If you click "Add topic" again, your comment will be added without a topic."
  5. Type something into the Topic field.
  6. Remove the text you just typed in that field.
  7. Click the Add Topic button again.

Observed Result:
This time it will let you post the discussion without any topic name.

Related Objects

Event Timeline

Ryasmeen created this task.Jan 20 2021, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2021, 7:57 PM
Ryasmeen updated the task description. (Show Details)Jan 20 2021, 7:59 PM
Ryasmeen added a comment.EditedJan 20 2021, 8:54 PM

This also happens if you just click the Add Topic button twice. So it's just doing one time validation check and not checking after that. Is it meant to be a soft warning rather than an enforced validation?

Ryasmeen added a parent task: T269285: Implement title field validation.Jan 20 2021, 9:25 PM
Ryasmeen mentioned this in T269285: Implement title field validation.Jan 20 2021, 9:36 PM
• iamjessklein awarded a token.Jan 21 2021, 1:40 PM
• ppelberg closed this task as Invalid.Jan 22 2021, 2:57 AM
In T272535#6763497, @Ryasmeen wrote:

This also happens if you just click the Add Topic button twice. So it's just doing one time validation check and not checking after that. Is it meant to be a soft warning rather than an enforced validation?

Exactly – the tool, for right now, offers a warning if someone does not enter any content into the Topic field, thus why the behavior you described in the task description and in T272535#6763497 is as it is.

With the above said, I'm glad you filed this for it led me to this issue: T272666.

Ryasmeen added a comment.Jan 22 2021, 8:33 PM
In T272535#6767831, @ppelberg wrote:
In T272535#6763497, @Ryasmeen wrote:

This also happens if you just click the Add Topic button twice. So it's just doing one time validation check and not checking after that. Is it meant to be a soft warning rather than an enforced validation?

Exactly – the tool, for right now, offers a warning if someone does not enter any content into the Topic field, thus why the behavior you described in the task description and in T272535#6763497 is as it is.

With the above said, I'm glad you filed this for it led me to this issue: T272666.

Yes, seems like we broke this recently, after wmf.27 deployment. I modified the title of that task to reflect that.

matmarex removed a parent task: T269285: Implement title field validation.Jan 29 2021, 10:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL