Page MenuHomePhabricator

Adding a filter then changing tabs yields no results
Closed, ResolvedPublic

Description

A recent change in logic introduced the following bug:

  • Perform a search
  • Add a filter
  • Change tabs
  • You will see the no results message

Event Timeline

Reverthing this commit will fix some of this behavior. In that case, you can still create the following erroneous scenario:

  • Perform a search in one tab
  • switch to another tab
  • add some filters (the current tab will load new results)
  • switch back to the original tab: the previously-loaded results have been discarded and get reloaded again.

The filters only apply to the second tab, so the results of the first tab should not be discarded. They do get loaded successfully, but we shouldn't have to do it at all.

Change 657410 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Distinguish between null continue value and unknown one

https://gerrit.wikimedia.org/r/657410

Change 657410 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Distinguish between null continue value and unknown one

https://gerrit.wikimedia.org/r/657410

Change 657623 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.27] Distinguish between null continue value and unknown one

https://gerrit.wikimedia.org/r/657623

Change 657623 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.27] Distinguish between null continue value and unknown one

https://gerrit.wikimedia.org/r/657623

Mentioned in SAL (#wikimedia-operations) [2021-01-22T01:12:57Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.27/extensions/WikibaseMediaInfo/: 4b0259b761681ca90b3f3039019553ddca40a5fe: Distinguish between null continue value and unknown one (T272548) (duration: 00m 59s)

Etonkovidova added a subscriber: Etonkovidova.

Checked in commons wmf.27 - seems that all patches have been deployed.

Behaves as expected. Also re-checked the browser back button behavior - also works as expected.