Page MenuHomePhabricator
Create Task
Maniphest T272560

Hard deprecate RevisionStore::newMutableRevisionFromArray
Closed, ResolvedPublic
Actions

Description

Soft-deprecated since 1.31, time to replace all usages with direct construction of MutableRevisionRecord and hard-deprecate.

Details

SubjectRepoBranchLines +/-
Hard deprecate RevisionStore::newMutableRevisionFromArraymediawiki/coremaster+52 -10
Replace use of newMutableRevisionFromArray within `new MutableRevisionRecord`mediawiki/extensions/Echomaster+18 -11
Replace use of newMutableRevisionFromArray within `new MutableRevisionRecord`mediawiki/extensions/EventBusmaster+49 -4
Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.Jan 21 2021, 4:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2021, 4:20 AM
Aklapper added a project: MediaWiki-Core-Revision-backend.Jan 21 2021, 8:40 AM
• Pchelolo triaged this task as Low priority.Jan 21 2021, 8:49 PM
• Pchelolo moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
• Pchelolo mentioned this in T272886: Start conversion of RevisionStore public interface to PageIdentity.Jan 25 2021, 5:53 PM
• Pchelolo raised the priority of this task from Low to High.Jan 27 2021, 6:06 PM
gerritbot added a comment.Jan 28 2021, 11:31 AM

Change 659238 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] Hard deprecate RevisionStore::newMutableRevisionFromArray

https://gerrit.wikimedia.org/r/659238

gerritbot added a project: Patch-For-Review.Jan 28 2021, 11:32 AM
• Pchelolo moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Feb 1 2021, 6:38 PM
gerritbot added a comment.Feb 2 2021, 5:35 PM

Change 661154 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Echo@master] Replace use of newMutableRevisionFromArray within direct costuction

https://gerrit.wikimedia.org/r/661154

gerritbot added a comment.Feb 3 2021, 9:54 AM

Change 661339 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/EventBus@master] Replace use of newMutableRevisionFromArray within new MutableRevisionRecord

https://gerrit.wikimedia.org/r/661339

gerritbot added a comment.Feb 3 2021, 1:48 PM

Change 661339 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Replace use of newMutableRevisionFromArray within new MutableRevisionRecord

https://gerrit.wikimedia.org/r/661339

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 3 2021, 2:00 PM
• Pchelolo moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Feb 3 2021, 10:24 PM
gerritbot added a comment.Feb 3 2021, 10:52 PM

Change 661154 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replace use of newMutableRevisionFromArray within new MutableRevisionRecord

https://gerrit.wikimedia.org/r/661154

gerritbot added a comment.Feb 4 2021, 12:31 AM

Change 659238 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate RevisionStore::newMutableRevisionFromArray

https://gerrit.wikimedia.org/r/659238

Maintenance_bot removed a project: Patch-For-Review.Feb 4 2021, 1:10 AM
• Pchelolo closed this task as Resolved.Feb 22 2021, 7:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL