Page MenuHomePhabricator

Adjust order of Special characters in editor toolbar; add brackets useful for Korean
Closed, ResolvedPublic

Description

Followup to T270157:

This is the repost of T270157#6764163.

Hello. Can I update one version more? I tried to adjust the order of symbols.

If you have to intend, You can include four more characters. I tried another file to make it more.

「 (U+300C) LEFT CORNER BRACKET
」 (U+300D) RIGHT CORNER BRACKET
『 (U+300E) LEFT WHITE CORNER BRACKET
』 (U+300F) RIGHT WHITE CORNER BRACKET

Thank you for reviewing in advance.

Event Timeline

mkbriggs added a subscriber: mkbriggs.

I'd like to work on this! I'll review those two links.

Hi and welcome @mkbriggs! Thanks in advance! If you need any help, feel free to ask!

Change 658496 had a related patch set uploaded (by MarikoBriggs; owner: MarikoBriggs):
[mediawiki/core@master] Adjust order of symbols, add corner brackets to special character toolbar

https://gerrit.wikimedia.org/r/658496

Aklapper renamed this task from [T270157 Update] Adjust the order of Special characters toolbar in the Editor to Adjust order of Special characters useful for Korean in editor toolbar; add brackets.Feb 15 2021, 10:55 AM
Aklapper updated the task description. (Show Details)

Patch needs rebase already (sorry), plus it has a few dangling tabs and spaces which should be removed (see the diff view on Gerrit).

@mkbriggs: Hi! Could you maybe share an update? Do you still plan to work on this task by amending the patch, or do you need any help? Thanks!

So I think now is the time for trying to submit it to Gerrit directly.

@ellif: Feel free to do so and amend the patch.

matmarex added a subscriber: matmarex.

I noticed the patch on Gerrit while I was reviewing the one for T286999. I'm having a look at this one as well now.

The patch makes significant changes to the order. It's difficult to describe them all, so here are screenshots instead:

BeforeAfter
image.png (491×2 px, 142 KB)
image.png (491×2 px, 142 KB)
1~ | ¡ ¿ † ‡
2↔ ↑ ↓
3
4¶ #
5½ ⅓ ⅔ ¼ ¾ ⅛ ⅜ ⅝ ⅞
6
7‘ ’
8¹ ² ³
9↘ ↗ ⇐ ⇒ ⇘ ⇗ ⇔
10△ ▲ □ ■ ○ ◎ ● ☆ ★ ◁ ◀ ▷ ▶ ◇ ◆ ㈜
11¥ ₩
12
13“” „“ „” «» ‹› ⟨⟩ 〈〉 《》
14¤
15₳ ฿ ₵ ¢ ₡ ₢ $ ₫ ₯ € ₠ ₣ ƒ ₴ ₭ ₤ ℳ ₥ ₦ № ₧ ₰ £ ៛ ₹ ₨ ₪ ৳ ₮ ₩ ¥
16♠ ♣ ♥ ♦
17m² m³
18– — …
19“ ”
20° % ‰ ′ ″ ≈ ≠ ≤ ≥ ± − × ÷
21← → ·
22§ ‽
23nbsp
1~ | ¡ ¿ † ‡
2¶ #
3
4‘ ’ “” „“ „” «» ‹› ⟨⟩ 〈〉 《》 「」 『』
5– — · • … ‽ ―
6¹ ² ³
7½ ⅓ ⅔ ¼ ¾ ⅛ ⅜ ⅝ ⅞
8← → ↑ ↓ ↔ ↘ ↗ ⇐ ⇒ ⇘ ⇗ ⇔
9¤
10₳ ฿ ₵ ¢ ₡ ₢ $ ₫ ₯ € ₠ ₣ ƒ ₴ ₭ ₤ ℳ ₥ ₦ № ₧ ₰ £ ៛ ₹ ₨ ₪ ৳ ₮ ₩ ¥
11¥ ₩
12♠ ♣ ♥ ♦
13△ ▲ □ ■ ○ ◎ ● ☆ ★ ◁ ◀ ▷ ▶ ◇ ◆ ㈜
14° % ‰ ′ ″ ≈ ≠ ≤ ≥ ± − × ÷ §
15m² m³
16nbsp

At first this seemed scary, but after comparing the lists, I think the new one is much better, so changing the order (and potentially requiring the users to learn the new order) seems worth it. The characters are grouped more sensibly (e.g. all arrows are grouped together, all numbers are grouped together, all quote marks are grouped together).

Also note that two unpaired quote marks were removed ( and ), as they are already included as a pair. Korean paired quote marks are added instead (「」 and 『』). There are no other additions or removals, just changes in the order.

Also, to be clear, the order is changed for everyone, not just Korean editors.

Change 658496 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.language: Adjust order of special characters useful in Korean

https://gerrit.wikimedia.org/r/658496

matmarex renamed this task from Adjust order of Special characters useful for Korean in editor toolbar; add brackets to Adjust order of Special characters in editor toolbar; add brackets useful for Korean.Aug 4 2021, 1:10 PM
matmarex added a project: Skipped QA.

@matmarex: a couple of questions for you...

  1. Would it be accurate for me to think the changes you showed in T272573#7256725 were limited to the Symbols section of the special characters toolbar [i][ii]?
  2. The changes to the groupings you shared make sense [iii]. Can you share the thinking that led to the order of the groupings themselves to be changed?

i. https://www.mediawiki.org/wiki/VisualEditor/Special_characters
ii.

Screen Shot 2021-08-09 at 6.08.23 PM.png (642×2 px, 160 KB)

iii. "...e.g. all arrows are grouped together, all numbers are grouped together, all quote marks are grouped together..."

  1. Yes
  2. I don't know, the change was proposed by @ellif and @mkbriggs. Perhaps they can share their thinking.

Does this need design review? (I doesn't seem that important, nor has the design changed - if there are wider questions about the design of this tool that should happen in another task)