Page MenuHomePhabricator

Translated content should use a darker text color
Closed, ResolvedPublic

Description

When the user applies a proposed translation, the text should be black (Base10: #202122) to allow users to distinguish it from the untranslated content. Currently, the translated text is shown with the same grey used for untranslated one.

Base10 should be used for translated text (regardless of whether it is selected or not).

In the example below you can see that the sentence above the current selected one is displayed in grey text:

afs7yIa.png (1×720 px, 175 KB)

The example is based on a translation of the "Names" section of the "Mars" from English to Spanish in the test server. You can reproduce it by:

  1. Select the "Names" section and start the translation.
  2. Click "Apply" several times.
  3. Observe that the content translated above the current selected sentence is shown in grey, compared to the text in the selection which is black (Base10). Expected result: translated content and the current selection should be darker (Base10) than untranslated content (grey).

Event Timeline

Change 658232 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Fix color for already translated sentences

https://gerrit.wikimedia.org/r/658232

Change 658232 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Fix color for already translated sentences

https://gerrit.wikimedia.org/r/658232

Jpita updated the task description. (Show Details)
Jpita updated the task description. (Show Details)

can't see this on sx-labs yet

@KartikMistry any idea why this is not visible in the test instance? It was merged two days ago (T272583#6792086).

@Pginer-WMF this is not yet deployed because also test server is not really in sync with our master. Functionalities are deployed on server only after we include a patch inside a CX3 build patch. As you can see from our last CX3 build patch, this patch was not included so it's not yet visible on server.

@Pginer-WMF this is not yet deployed because also test server is not really in sync with our master. Functionalities are deployed on server only after we include a patch inside a CX3 build patch. As you can see from our last CX3 build patch, this patch was not included so it's not yet visible on server.

how do we know when it is deployed?
can we not move tasks to QA before they are on the test server?

Each CX3 build patch includes a reference to last commit on master included to this patch. We generally do not move tickets to QA column before they are deployed, but this was a confusing edge-case and I inadvertently moved it there.

image.png (96×1 px, 29 KB)
As you can see, this patch was merged before last CX3 build but was not included in the build, which led to this confusion.

@Pginer-WMF I can barely tell the difference between translated and not, is this what's expected?

image.png (884×498 px, 96 KB)

image.png (2×1 px, 1 MB)

@Pginer-WMF I can barely tell the difference between translated and not, is this what's expected?

Yes, the color difference is a bit subtle but this is as intended. The idea is to provide an additional clue to the text being in a different language.

Additional background: We don't have much room in the palette to make the untranslated text lighter without making it too hard to read, and additional visual signals can be too distracting.