| Pginer-WMF | |
| Jan 21 2021, 12:01 PM |
| F35372273: image.png | |
| Aug 1 2022, 5:54 AM |
| F35372271: image.png | |
| Aug 1 2022, 5:54 AM |
| F35339542: Screenshot 2022-07-26 at 12.07.37.png | |
| Jul 26 2022, 10:21 AM |
| F35310362: image.png | |
| Jul 7 2022, 6:02 AM |
Some wikis require a captcha to be filled when publishing.
When users click on "publish", if the target wiki requests a captcha, users should be able to fill it. Ideally, the captcha dialog should be the same as used in Mobile VisualEditor.
As a reference, this is similar to what was done for Content Translation (T189766) and several aspects of that discussion may still be relevant.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T243495 [Epic] Support for Section Translation | |||
| Open | None | T252542 Section Translation Editor: Preview and publish | |||
| Resolved | ngkountas | T272586 SX: Show the captcha confirmation dialog when the target wiki requests it |
Change 810013 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX: Add CAPTCHA confirmation dialog before publishing, when needed
For testing we may want to check how this works when creating an article with a new user account on Turkish Wikipedia, since it is a wiki where Section Translation is available and apparently they have the captcha enabled according to T24027: Enable AbuseFilter and Captcha on Turkish Wikipedia
Screenshot from the above patch for @Pginer-WMF to review. To me, after filling the answer there was a confusion on how to submit. Pressing enter key did not do anything. Tick mark as primary action was not obvious since it has no color difference.
Good points, Santhosh. The dialog section on the style guide provides more details (check "complex dialogs" and notes on their use on mobile).
Based on that, we can consider the following adjustments:
Change 810013 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX: Add CAPTCHA confirmation dialog before publishing, when needed
Change 818992 had a related patch set uploaded (by Santhosh; author: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220801
Change 818992 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220801
Screenshots from latest patch:
Narrow screen Wid screen
Thanks for sharing the screenshots. Looking at the wide screen, there seems not to be separation between the end of the title and the "publish" button. This was not explicitly captured in the style guide mockup, but I think it would benefit to have a 16px space before the button to make sure that text does not get too close to it.
I created a follow-up ticket with the (small) pending adjustments: T319280: Captcha dialog on mobile translations needs space between title and button. So I guess we can close this ticket now. Thanks everyone!
