Page MenuHomePhabricator

Better handle long attribute changes
Closed, ResolvedPublic

Description

Some things that are considered "node attributes" can be quite long:

  • External link URLs
  • Template parameters

The diff shows all attribute changes as remove/insert which can be quite hard to read, and take up a lot of lines in the sidebar, e.g. https://en.wikipedia.org/w/index.php?title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual

We could run a linear diff on attribute changes to make this shorter and more legible.

BeforeAfter

Event Timeline

Change 657680 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Show attribute changes as diffs when appropriate

https://gerrit.wikimedia.org/r/657680

Change 657680 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Show attribute changes as diffs when appropriate

https://gerrit.wikimedia.org/r/657680

Change 657883 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca6a97f42)

https://gerrit.wikimedia.org/r/657883

Change 657899 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca6a97f42)

https://gerrit.wikimedia.org/r/657899

Change 657883 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca6a97f42)

https://gerrit.wikimedia.org/r/657883

Change 657899 abandoned by Bartosz Dziewoński:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca6a97f42)

Reason:
Duplicate of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /657883 (looks like we submitted them at the same time)

https://gerrit.wikimedia.org/r/657899

@Esanders are you able to post a screenshot of what the new experience looks like? //I'm assuming the one you posted in the task description [i] is of the existing state.


i. https://en.wikipedia.org/w/index.php?title=Eight_Legged_Freaks&curid=956388&diff=1000619828&oldid=1000322446&diffmode=visual

matmarex added a subscriber: matmarex.

Added better before/after screenshots.

ppelberg claimed this task.

Added better before/after screenshots.

Thank you.