Page MenuHomePhabricator

fix checkbox issues
Open, LowPublicBUG REPORT

Assigned To
None
Authored By
Charlie_WMDE
Jan 21 2021, 3:23 PM
Referenced Files
F34400396: Screenshot 2021-04-15 at 18.49.14.png
Apr 15 2021, 4:55 PM
F34149554: Screenshot 2021-03-10 at 12.49.14.png
Mar 10 2021, 12:00 PM
F34105524: Screenshot 2021-02-15 at 10.20.32.png
Feb 15 2021, 9:21 AM
F34038328: image.png
Jan 27 2021, 10:00 AM
F34011086: image.png
Jan 21 2021, 3:23 PM
F34011091: image.png
Jan 21 2021, 3:23 PM
F34011088: image.png
Jan 21 2021, 3:23 PM

Description

  1. Somewhere around a viewport of 493px the checkboxes start compressing. That should not be happening - ✅ FIXED
  1. The spacing between the two checkboxes is not correct (link to figma)

image.png (205×1 px, 27 KB)

  1. Spacing between text and number input field is not correct (link to figma)

image.png (114×631 px, 15 KB)

  1. The checkbox input should always remain center-aligned with the first line of text if the label wraps: ✅ FIXED
  1. Suffix icons should be aligned with the top or the baseline of the first line of wrapping labels, instead of being centered in relation to the whole label text. This would prevent misalignment like the following in checkboxes (although the change should apply to all labels):

Screenshot 2021-03-10 at 12.49.14.png (363×575 px, 30 KB)

  1. There's currently no space between the value input and the related checkbox option. Following the designs, there should be an 8px separation between the two elements.

Screenshot 2021-04-15 at 18.49.14.png (190×570 px, 16 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Problem 1 should be fixable in the Checkbox component in wikit by adding a min-width next to the width with the same value.

This is fixed, just needs releasing.

Michael changed the subtype of this task from "Task" to "Bug Report".Feb 12 2021, 5:28 PM
Lydia_Pintscher subscribed.

Setting to low for the remaining issues.

The only remaining fix in this ticket that is related to WiKit is number 5 ("Suffix icons should be aligned with the top or the baseline of the first line of wrapping labels"). This is not a critical fix and I actually have doubts about whether it can actually be achieved :-/