Remove any unused rules from ext.securepoll.css (OT)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Jan 21 2021, 3:44 PM

Description

Some of the rules in the file ext.securepoll.css appear unused since T271149: Convert SecurePoll CreatePage to use OOUI and T271150: Convert SecurePoll VoterEligibilityPage to use OOUI, and should have been removed while fixing those issues.

This task is for removing any unused rules:

Check which pages load ext.securepoll.css
Check which rules in ext.securepoll.css no longer apply to any elements on those pages
Remove the unused rules

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove any unused rules from ext.securepoll.css	mediawiki/extensions/SecurePoll	master	+1 -27

Customize query in gerrit

Related Objects

Mentioned In: T270648: Load style module for no-JS environments in VoterEligibilityPage (OT)
Mentioned Here: T271149: Convert SecurePoll CreatePage to use OOUI
T271150: Convert SecurePoll VoterEligibilityPage to use OOUI

Event Timeline

Tchanders created this task.Jan 21 2021, 3:44 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJan 21 2021, 3:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tchanders mentioned this in T270648: Load style module for no-JS environments in VoterEligibilityPage (OT).Jan 21 2021, 3:45 PM

• wikitrent claimed this task.Jan 21 2021, 4:51 PM

ARamirez_WMF moved this task from Onboarding Tasks to The Letter Song on the Anti-Harassment-Team board.Jan 21 2021, 4:51 PM

ARamirez_WMF edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.

• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Jan 21 2021, 4:53 PM

• AMooney removed a project: Platform Engineering.Jan 26 2021, 4:52 PM

Change 659052 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Remove any unused rules from ext.securepoll.css

https://gerrit.wikimedia.org/r/659052

gerritbot added a project: Patch-For-Review.Jan 27 2021, 6:23 PM

• wikitrent moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jan 27 2021, 7:08 PM

Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment-Team (The Letter Song) board.Jan 28 2021, 3:23 PM

Change 659052 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove any unused rules from ext.securepoll.css

https://gerrit.wikimedia.org/r/659052

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 28 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 4:10 PM

Niharika closed this task as Resolved.Feb 8 2021, 12:42 PM