WikibaseLexeme special page browser tests do not run
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

I just noticed that some of the WikibaseLexeme browser tests don’t seem to run: they use the long-removed WebdriverIO function isVisible (now called isDisplayed), but CI reports no error, and their test names are also not visible in CI output.
I assume this is because tests/selenium/wdio.conf.js specifies the specs as specs/*.js, but those tests are in specs/special/*.js, which I guess isn’t included in that glob.

Acceptance Criteria

All browser tests in WikibaseLexeme run in CI
Tests pass in CI

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WIP: Selenium: run all test specs	mediawiki/extensions/WikibaseLexeme	master	+4 -4
	Include spec/special browser tests in CI	mediawiki/extensions/WikibaseLexeme	master	+29 -20

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 21 2021, 5:16 PM

Change 657645 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Selenium: run all test specs

https://gerrit.wikimedia.org/r/657645

gerritbot added a project: Patch-For-Review.Jan 21 2021, 5:19 PM

Addshore added a project: [DEPRECATED] wdwb-tech (legacy-backlog).Jan 22 2021, 11:47 PM

Addshore moved this task from Incoming to 3. Fill ins (-I -E) on the [DEPRECATED] wdwb-tech (legacy-backlog) board.Jan 27 2021, 1:29 PM

Addshore added a project: Wikidata-Campsite.Feb 23 2021, 12:33 PM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

Addshore updated the task description. (Show Details)Feb 23 2021, 1:04 PM

darthmon_wmde set the point value for this task to 5.Feb 25 2021, 10:06 AM

Addshore moved this task from 3. Fill ins (-I -E) to Active on the [DEPRECATED] wdwb-tech (legacy-backlog) board.Feb 25 2021, 10:06 AM

Addshore moved this task from incoming to in progress on the Wikidata board.

darthmon_wmde moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Feb 25 2021, 10:07 AM

darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

• noarave claimed this task.Mar 1 2021, 1:15 PM

Restricted Application added a project: User-Noarave. · View Herald TranscriptMar 1 2021, 1:15 PM

• noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 1 2021, 1:15 PM

Change 668648 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseLexeme@master] Lexeme CI test: include spec/special browser tests

https://gerrit.wikimedia.org/r/668648

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 17 2021, 4:26 PM

Addshore moved this task from legacy-backlog to Active on the [DEPRECATED] wdwb-tech board.Mar 18 2021, 9:29 AM

Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).

Change 668648 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Include spec/special browser tests in CI

https://gerrit.wikimedia.org/r/668648

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 19 2021, 3:29 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 19 2021, 4:00 PM

Addshore closed this task as Resolved.Apr 7 2021, 8:55 AM

Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 7 2021, 9:16 AM

Change 657645 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/WikibaseLexeme@master] WIP: Selenium: run all test specs