Page MenuHomePhabricator

PageForms display=spreadsheet html escaping error
Closed, ResolvedPublic

Description

When using the display spreadsheet function, HTML escaped characters can have handling issues.

Before commit 3d9d2fc, the characters would display properly in the spreadsheet, but save to the form with the escaping still intact. There would be no indication other than using the edit button that this had occurred to the user.

After that commit, the escaping now cascades. Saving a new item with A&B will save to the template as item=A&B. It looks right the first time, but if it is opened back in the spreadsheet, it escapes it again, making the value inside the spreadsheet look like A&B and saves into the template as item=A&B.

Event Timeline

Change 833448 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/PageForms@master] Fix repeated escaping problem in "spreadsheet" display

https://gerrit.wikimedia.org/r/833448

Change 833448 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Fix repeated escaping problem in "spreadsheet" display

https://gerrit.wikimedia.org/r/833448

Please feel free to reopen this task if the issue persists