ConvertibleTimestamp::getTimestamp: The timestamp cannot be represented in the specified format
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message

Wikimedia\Timestamp\ConvertibleTimestamp::getTimestamp: The timestamp cannot be represented in the specified format

Stack Trace

from /srv/mediawiki/php-1.36.0-wmf.27/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(330)
#0 /srv/mediawiki/php-1.36.0-wmf.27/includes/libs/ParamValidator/TypeDef/TimestampDef.php(104): Wikimedia\Timestamp\ConvertibleTimestamp->getTimestamp(integer)
#1 /srv/mediawiki/php-1.36.0-wmf.27/includes/libs/ParamValidator/ParamValidator.php(597): Wikimedia\ParamValidator\TypeDef\TimestampDef->validate(string, string, array, array)
#2 /srv/mediawiki/php-1.36.0-wmf.27/includes/libs/ParamValidator/ParamValidator.php(551): Wikimedia\ParamValidator\ParamValidator->validateValue(string, string, array, array)
#3 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/Validator/ApiParamValidator.php(363): Wikimedia\ParamValidator\ParamValidator->getValue(string, array, array)
#4 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiBase.php(1045): MediaWiki\Api\Validator\ApiParamValidator->getValue(ApiQueryAllImages, string, array, array)
#5 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiBase.php(733): ApiBase->getParameterFromSettings(string, array, boolean)
#6 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiQuery.php(266): ApiBase->extractRequestParams()
#7 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiMain.php(1612): ApiQuery->execute()
#8 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiMain.php(592): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiMain.php(563): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.36.0-wmf.27/api.php(90): ApiMain->execute()
#11 /srv/mediawiki/php-1.36.0-wmf.27/api.php(45): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}

Impact

2 of these seen since deploy of 1.36.0-wmf.27 (T271341) to all wikis.

Details

Request ID: YAnquApAMNsAAJfvH4UAAABE
Request URL: https://en.wikipedia.org/w/api.php?action=query&list=allimages&ailimit=50&format=json&aisort=timestamp&aistart=2014815210101&callback=jQuery35107323408282974431_1611262648041&_=1611262648042

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Tighten invalid timestamp error checking	mediawiki/core	master	+19 -5

Customize query in gerrit

Related Objects

Mentioned In: T304295: Wikimedia\Timestamp\ConvertibleTimestamp::getTimestamp: The timestamp cannot be represented in the specified format
Mentioned Here: T271341: 1.36.0-wmf.27 deployment blockers

Event Timeline

brennen created this task.Jan 21 2021, 9:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2021, 9:17 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jan 21 2021, 9:18 PM

The URL was probably manually tinkered with.

Indeed, "2014815210101" is not a valid timestamp. But validation and error handling could be improved.

• holger.knust edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jan 26 2021, 9:14 PM

• holger.knust moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

• AMooney triaged this task as Lowest priority.Jan 26 2021, 9:19 PM

• AMooney raised the priority of this task from Lowest to Low.

This exposes uncached fatal errors to a public GET-able http address. I would generally treat those as high priority. The API validation needs to catch these and reject them gracefully with an error message, not crash like it does now, which would raise error levels, and may abort deployments or cause SRE alerts to fire at unexpected times.

daniel triaged this task as Medium priority.Jan 28 2021, 3:01 PM

• AMooney moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.Feb 2 2021, 3:19 PM

Change 661685 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Tighten invalid timestamp error checking

https://gerrit.wikimedia.org/r/661685

gerritbot added a project: Patch-For-Review.Feb 4 2021, 9:28 AM

Change 661685 merged by jenkins-bot:
[mediawiki/core@master] Tighten invalid timestamp error checking

https://gerrit.wikimedia.org/r/661685

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 13 2021, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2021, 7:10 AM

Ammarpad closed this task as Resolved.Feb 16 2021, 12:51 PM

Ammarpad claimed this task.

dom_walden mentioned this in T304295: Wikimedia\Timestamp\ConvertibleTimestamp::getTimestamp: The timestamp cannot be represented in the specified format.Mar 21 2022, 11:24 AM

ConvertibleTimestamp::getTimestamp: The timestamp cannot be represented in the specified formatClosed, ResolvedPublicPRODUCTION ERRORActions