Comment highlight appears in an unexpected position
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Jan 22 2021, 2:57 AM

Description

Behavior

On a wiki where the New Discussion Tool, visit a page with existing conversations (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Ppelberg-test)
Open the New Discussion Tool
Enter text into the Description field. Note: do NOT enter text into the Topic field.
Click the Add topic button

Actual

❗️The "highlight" appears atop the first comment in the last section on the page.

Expected

✅The "highlight" appears atop the text you drafted in "Step 3." and published in "Step 4."

Done

"Expected behavior" is implemented

Details

Subject	Repo	Branch	Lines +/-
Fix highlight when new topic is posted without a title	mediawiki/extensions/DiscussionTools	wmf/1.36.0-wmf.31	+14 -3
Fix highlight when new topic is posted without a title	mediawiki/extensions/DiscussionTools	wmf/1.36.0-wmf.30	+14 -3
Fix highlight when new topic is posted without a title	mediawiki/extensions/DiscussionTools	master	+14 -3

Customize query in gerrit

Related Objects

Mentioned In: T312713: If you double-sign a single message, then only the second part is highlighted
T274949: Immortal comment follows me across pages
T273145: Deploy config change to make New Discussion Tool available as beta feature
T272535: New Discussion Tool lets you post a discussion without a topic if you remove the topic name
Mentioned Here: rEDTO6b88aff7df59: Make new topic autosave specific to page title
rEDTO1cc29dfe55eb: Fix highlight when new topic is posted without a title
T274949: Immortal comment follows me across pages
rEDTO9c6cdf56d013: Fix highlight when new topic is posted without a title
rEDTO97acef64bcb2: Make new topic autosave specific to page title

Event Timeline

• ppelberg created this task.Jan 22 2021, 2:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2021, 2:57 AM

• ppelberg mentioned this in T272535: New Discussion Tool lets you post a discussion without a topic if you remove the topic name .Jan 22 2021, 2:57 AM

Ryasmeen renamed this task from Comment highlight appears in an unexpected position to [Regression pre-wmf.28] Comment highlight appears in an unexpected position.Jan 22 2021, 8:27 PM

I can't replicate this anymore, is this still happening?

I can reproduce. There are some more scenarios where the highlight is wrong. For example, if you post a comment with two signatures on separate paragraphs (only the first paragraph gets highlighted) or if you add a sub-heading inside your comment (only the subheading and below gets highlighted).

After you post a new topic, we always highlight the heading of the last section on the page, and the first comment underneath. This is usually correct, but it can fail if you use interesting markup like that, and our comment parser gets confused about the comment boundaries. It's annoyingly difficult to do this better, and I don't think it's a priority.

(not a regression, it was always like this in New Discussion Tool)

In T272666#6775660, @matmarex wrote:

After you post a new topic, we always highlight the heading of the last section on the page, and the first comment underneath. This is usually correct, but it can fail if you use interesting markup like that, and our comment parser gets confused about the comment boundaries.

This is helpful context.

It's annoyingly difficult to do this better, and I don't think it's a priority.

Understood, agreed and accordingly, marking this is "triaged" and keeping in backlog.

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jan 26 2021, 12:49 AM

In T272666#6775660, @matmarex wrote:

It's annoyingly difficult to do this better, and I don't think it's a priority.

Well, now that we got a bug report about it from a real user… ;) maybe it's worth fixing this case.

Change 664807 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix highlight when new topic is posted without a title

https://gerrit.wikimedia.org/r/664807

gerritbot added a project: Patch-For-Review.Feb 17 2021, 12:26 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Feb 17 2021, 12:27 PM

matmarex mentioned this in T273145: Deploy config change to make New Discussion Tool available as beta feature .Feb 17 2021, 1:40 PM

Change 664807 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix highlight when new topic is posted without a title

https://gerrit.wikimedia.org/r/664807

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 18 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2021, 12:10 AM

Change 665166 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.30] Fix highlight when new topic is posted without a title

https://gerrit.wikimedia.org/r/665166

Change 665168 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.31] Fix highlight when new topic is posted without a title

https://gerrit.wikimedia.org/r/665168

Change 665166 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.30] Fix highlight when new topic is posted without a title

https://gerrit.wikimedia.org/r/665166

Change 665168 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.36.0-wmf.31] Fix highlight when new topic is posted without a title

https://gerrit.wikimedia.org/r/665168

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2021, 7:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-18T19:17:35Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/extensions/DiscussionTools/: 9c6cdf5: 97acef6: DiscussionTools backports (T272666; T274949) (duration: 01m 26s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T19:19:21Z] <urbanecm@deploy1001> sync-file aborted: 1cc29df DiscussionTools backports (T272666; T274949) (duration: 00m 00s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T19:20:49Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/DiscussionTools/: 1cc29df: 6b88aff: DiscussionTools backports (T272666; T274949) (duration: 01m 08s)