Wikisource Extension: ElectronPdfService links still appear on some wikis
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 22 2021, 9:02 AM

Description

As a Wikisource user, I don't want any links that use the ElectronPdfService to show, so that I only download PDFs via WS-Export, which is a more reliable service.

Background

If only the ElectronPdfService extension (but not the Collection extension) is installed, the ElectronPdfService link is not removed by the Wikisource extension.

I guess because it has its own <nav>, different from Collection, with id=p-electronpdfservice-sidebar-portlet-heading.

Looking in the production config, I think zhwikisource, srwikisource and zh_min_nanwikisource are the only wikisources with only ElectronPdfService installed.

Steps to reproduce problem

Go to https://sr.wikisource.org/wiki/%D0%91%D0%BE%D0%B6%D0%B8%D1%9B%D0%BD%D0%B5_%D0%BF%D1%80%D0%B8%D1%87%D0%B5?uselang=en

Expected behavior: In the left sidebar, you will only see one "Download PDF" link
Observed behavior: You see both "Download as PDF" and "Download PDF"

Screenshots (if applicable):

ws+electron_content.png (588×155 px, 25 KB)

Acceptance Criteria:

Fix bug so that "Download as PDF" link is no longer displayed to users

Details

	Subject	Repo	Branch	Lines +/-
	Handle ElectronPdfService sidebar portlet	mediawiki/extensions/Wikisource	master	+8 -5

Customize query in gerrit

Related Objects

Mentioned In: T272762: Create PDF button in Wikisource Mobile page menu doesn't use the exporter
T255790: Wikisource: Replace ElectronPDF with WSExport PDF support
Mentioned Here: rEEPS238c939c5658: Localisation updates from https://translatewiki.net.
rEWSOfe9e0fbd48fb: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Jan 22 2021, 9:02 AM

Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptJan 22 2021, 9:02 AM

dom_walden mentioned this in T255790: Wikisource: Replace ElectronPDF with WSExport PDF support.Jan 22 2021, 9:08 AM

Inductiveload mentioned this in T272762: Create PDF button in Wikisource Mobile page menu doesn't use the exporter.Jan 23 2021, 12:18 AM

ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jan 26 2021, 5:08 PM

ifried updated the task description. (Show Details)Feb 1 2021, 10:40 PM

ifried set the point value for this task to 3.Feb 2 2021, 12:49 AM

ifried moved this task from Needs Discussion to Ready on the Community-Tech board.

ifried moved this task from Ready to Kanban-2020-21-Q3 on the Community-Tech board.

ifried edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.

Samwilson claimed this task.Feb 2 2021, 1:51 AM

Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q3) board.

Change 661047 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Wikisource@master] Handle ElectronPdfService sidebar portlet

https://gerrit.wikimedia.org/r/661047

gerritbot added a project: Patch-For-Review.Feb 2 2021, 8:16 AM

Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q3) board.Feb 2 2021, 8:22 AM

Change 661047 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Handle ElectronPdfService sidebar portlet

https://gerrit.wikimedia.org/r/661047

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Feb 17 2021, 6:37 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 17 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2021, 7:10 PM

The "Download as PDF" link has been removed when only ElectronPdfService is installed.

The side bar now looks like:

For regression purposes, I checked that the sidebar on https://en.wikisource.beta.wmflabs.org was not changed.

Test environment: local vagrant Wikisource – (fe9e0fb), ElectronPdfService – (238c939).

I have tested with the link provided in the description, and we're now only seeing one "Download PDF" link (see screenshot attached below). I'm marking this work as Done.

Screen Shot 2021-03-12 at 3.06.09 PM.png (1×2 px, 1 MB)

Stang removed a subscriber: Stang.Nov 13 2021, 11:31 PM

	F34156049: Screen Shot 2021-03-12 at 3.06.09 PM.png
	Mar 12 2021, 8:07 PM

	F34113921: just_epdfs.png
	Feb 19 2021, 2:49 PM

Wikisource Extension: ElectronPdfService links still appear on some wikisClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions