Page MenuHomePhabricator

The caret is invisible due to focus outline of the textarea#mw-scribunto-input
Closed, ResolvedPublic

Description

This doesn't seem to be a specific skin problem, I can reproduce it in Timeless and Vector.

  1. Open any module editing page, like https://zh.wikipedia.org/w/index.php?title=Module:Citation/CS2&action=edit.
  2. Click on the gray textarea of the Debug console.

A colored border appears, but the textarea does not display the caret, which makes it look like a read-only standard output terminal, which once misled me.

Event Timeline

Aklapper changed the task status from Open to Stalled.Jan 22 2021, 12:09 PM

Hi @YFdyh000, thanks for taking the time to report this!
Where to find and see a debug console on that page? In which browsers was this tested? Could you maybe attach a screenshot? Thanks!

在T272678#6768705中,@Aklapper写道:

Hi @YFdyh000, thanks for taking the time to report this!
Where to find and see a debug console on that page? In which browsers was this tested? Could you maybe attach a screenshot? Thanks!

Sorry for the delay.
Opening like the https://zh.wikipedia.org/w/index.php?title=Module:Citation/CS2&action=edit&uselang=en (or https://testwiki.wiki/index.php?title=Module:Citation/CS2&action=edit&redlink=1), the grey box of "Debug console", it appears to be a read-only output label rather than an input and output terminal.

I see the issue in Edge 89 and earlier, Firefox looks good. I noticed the following rule using developer tools: :focus { outline: -webkit-focus-ring-color auto 1px; } from User Agent Style Sheets on #mw-scribunto-input, overwriting the rule with 0px will solve the issue.

YFdyh000 changed the task status from Stalled to Open.Mar 4 2021, 1:07 AM
Legoktm added a subscriber: Legoktm.

I can reproduce this in Chromium 103.0.5060.114, but Firefox 105.0.1 looks fine.

Change 839039 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Scribunto@master] Restore padding on #mw-scribunto-input to make cursor visible

https://gerrit.wikimedia.org/r/839039

I played with it a bit, I think restoring the default padding is probably less bad than compared to removing the :focus outline rule.

Change 839039 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Restore padding on #mw-scribunto-input to make cursor visible

https://gerrit.wikimedia.org/r/839039

Change 840290 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Scribunto@REL1_39] Restore padding on #mw-scribunto-input to make cursor visible

https://gerrit.wikimedia.org/r/840290

Change 840290 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@REL1_39] Restore padding on #mw-scribunto-input to make cursor visible

https://gerrit.wikimedia.org/r/840290