Page MenuHomePhabricator
Create Task
Maniphest T272682

(MS5) Open the query in the query service
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As an editor I want to open the visual query in the wikidata query service in order to see the resulting SPARQL code.

Problem:
At present the link to SPARQL query is in the result view and is not noticeable.

Screenshots/mockups:
desktop (layout 1-3)

image.png (213×790 px, 15 KB)

mobile (layout 4)
image.png (395×338 px, 17 KB)

BDD
GIVEN a visual query
AND
WHEN
AND
THEN
AND

Acceptance criteria:

  • A link from query builder to query.wikidata.org to display the SPARQL code.
  • link opens in a new tab

Notes:

  • doesn't have to use the link component or similar yet

Related Objects
Search...

Event Timeline

• amy_rc created this task.Jan 22 2021, 9:58 AM
Ladsgroup added a comment.Jan 22 2021, 10:01 AM

IIRC, this needs link component.

• amy_rc moved this task from Incoming to Backlog on the Wikidata Query Builder board.Jan 25 2021, 9:38 AM
Ladsgroup removed a parent task: T265240: intro text for expectation setting.Jan 25 2021, 12:37 PM

I removed this as subtask of T265240: intro text for expectation setting.

Lydia_Pintscher triaged this task as High priority.Jan 26 2021, 9:30 AM
Lydia_Pintscher added a subtask: T272958: (MS 5) Create link component.
Charlie_WMDE updated the task description. (Show Details)Jan 27 2021, 9:45 AM
Lydia_Pintscher updated the task description. (Show Details)Jan 27 2021, 10:39 AM
Lydia_Pintscher set the point value for this task to 5.
Lydia_Pintscher moved this task from Backlog to Ready to pick up on the Wikidata Query Builder board.
Ladsgroup claimed this task.Jan 28 2021, 7:54 AM
Ladsgroup moved this task from Ready to pick up to Doing on the Wikidata Query Builder board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 28 2021, 7:54 AM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder board.Jan 28 2021, 8:41 AM

https://github.com/wmde/query-builder/pull/174

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder board.Jan 29 2021, 4:54 PM
Charlie_WMDE added a comment.Feb 1 2021, 3:30 PM

looks good apart from the link only appearing after i've run the query. i'd expect it to always be there. if clicked before having ever run a query, it would just lead you to an empty QS page

Ladsgroup moved this task from Test (Verification) to Peer Review on the Wikidata Query Builder board.Feb 1 2021, 4:11 PM

Thanks put it in https://github.com/wmde/query-builder/pull/184

Michael moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder board.Feb 2 2021, 3:54 PM
Michael moved this task from Test (Verification) to Ready to pick up on the Wikidata Query Builder board.
Michael moved this task from Ready to pick up to Test (Verification) on the Wikidata Query Builder board.Feb 2 2021, 3:59 PM
• amy_rc added a comment.Feb 3 2021, 3:38 PM

The link works before and after a query is run. 💃 💃 \o/

• amy_rc moved this task from Test (Verification) to Done on the Wikidata Query Builder board.Feb 3 2021, 3:39 PM
Charlie_WMDE closed this task as Resolved.Feb 4 2021, 2:55 PM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Feb 4 2021, 3:15 PM
• amy_rc closed subtask T272958: (MS 5) Create link component as Resolved.Mar 9 2021, 12:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL