Page MenuHomePhabricator
Create Task
Maniphest T272692

(MS3) Query for specific property with values in a specific range
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As an editor I want to query data with values within a certain range in order to find all the results I am looking for, not just the ones with the exact values.

Problem:
Right now we can only query with exact matching for 'date' and 'quantity values'.

Example:

Screenshots/mockups:
date/time ranges
Label 1: before
Label 2: after

image.png (487×995 px, 42 KB)

quantity ranges
Label 1: less than
Label 2: more than
image.png (490×999 px, 46 KB)

BDD
GIVEN a visual query
WHEN querying for Properties of datatype time
THEN the editor can also choose one of 'before"/"after' in the dropdown

GIVEN a visual query
WHEN querying for Properties of datatype quantity
THEN the editor can also choose one of 'less than"/"more than' in the dropdown

Acceptance criteria:

  • Editors can choose between 'exact match' and 'range' for the given value when selecting a Property of datatype time or quantity.
  • Range options are only available for time and quantity values.
  • The range label varies depending on the datatype ("before"/"after" for time and "less than"/"more than" for quantity)

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• amy_rcT272692 (MS3) Query for specific property with values in a specific range
 Resolved• amy_rcT268942 (MS 3) query for quantity values
 ResolvedMichaelT273001 (MS 3) Create Quantity input component
 Resolved• amy_rcT273796 Create extended number input component
 ResolvedMichaelT273795 Investigation: Number input component
 ResolvedLadsgroupT275113 Validation for ExtendedNumberInput
 ResolvedLadsgroupT275114 Create actual extended number input component
 Resolvedguergana.tzatchkovaT276935 adjust value type in QueryRepresentation / Condition interfaces to account for unit values
 ResolvedMichaelT276938 (MS 3) Adjust buildQuery to produce correct SPARQL
 Resolvedguergana.tzatchkovaT276943 (MS 3)create QuantityValueInput component in QueryBuilder
 ResolvedMichaelT276944 (MS 3) Validation of Quantity number input
 Resolvedguergana.tzatchkovaT277034 Adjust Value interface in RootStore by adding QuantityValue type to it
 ResolvedMichaelT277035 (MS 3)Ensure that link-sharing still works
 ResolvedMichaelT277036 (MS 3) Wire up QuantityInput
 Resolvedguergana.tzatchkovaT277670 Add scroll event to QuantityInput component
 Resolved• amy_rcT272697 (MS 6) Query for date values
 ResolvedLadsgroupT273002 (MS 6) Create Date input component
 ResolvedLadsgroupT275758 (MS 6) Create InputWithExtender component
 Resolved• beteT277038 (MS 6) Create ParseValueRepository
 ResolvedMichaelT277039 (MS 6) create SPARQL for date queries
 Resolved• beteT277057 (MS 6) Create FormatValueRepository
 Resolved• beteT277847 Adjust the RootState to store the parsed value
 ResolvedMichaelT277848 Create an action for the DateValueInput to call on user input
 Resolved• beteT277850 Create DateValueInput component
 Resolved• beteT277851 Adjust QueryRepresentation to include DateValue
Resolved• beteT277853 Wire up DateValueInput and create browser tests
 Resolved• beteT277854 Ensure that link-sharing still works with Date Queries
 Resolvedguergana.tzatchkovaT279626 Add additional property value relation types to PropertyValueRelation
 ResolvedMichaelT279627 Show new property value relation types in the dropdown for quantity datatypes
 ResolvedMichaelT279629 Adjust the SPARQL generation for datatype quantity
 ResolvedMichaelT279630 Show new property value relation types in the dropdown for quantity datatypes
 ResolvedMichaelT279631 Adjusting the SPARQL generation for datatype date to allow for before and after

Event Timeline

• amy_rc created this task.Jan 22 2021, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2021, 11:27 AM
• amy_rc updated the task description. (Show Details)Jan 25 2021, 9:36 AM
• amy_rc moved this task from Incoming to Backlog on the Wikidata Query Builder board.
Charlie_WMDE updated the task description. (Show Details)Jan 25 2021, 5:46 PM
Lydia_Pintscher triaged this task as High priority.Jan 26 2021, 9:28 AM
Lydia_Pintscher moved this task from Backlog to Ready for story time on the Wikidata Query Builder board.
Lydia_Pintscher added subtasks: T268942: (MS 3) query for quantity values, T272697: (MS 6) Query for date values.Jan 26 2021, 10:07 AM
Lydia_Pintscher updated the task description. (Show Details)Feb 16 2021, 9:27 AM
Lydia_Pintscher mentioned this in T268942: (MS 3) query for quantity values.Feb 16 2021, 9:31 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher updated the task description. (Show Details)Feb 16 2021, 9:38 AM
Lydia_Pintscher mentioned this in T272697: (MS 6) Query for date values.Feb 16 2021, 9:42 AM
Michael renamed this task from (MS3) Query for specific property with values in a specific range to (MS3) 🛑 Query for specific property with values in a specific range.Feb 24 2021, 1:04 PM
Lydia_Pintscher set the point value for this task to 5.Mar 3 2021, 1:24 PM
Lydia_Pintscher moved this task from Ready for story time to Ready to pick up on the Wikidata Query Builder board.
Michael renamed this task from (MS3) 🛑 Query for specific property with values in a specific range to (MS3) Query for specific property with values in a specific range.Apr 7 2021, 7:08 PM
guergana.tzatchkova closed subtask T279626: Add additional property value relation types to PropertyValueRelation as Invalid.Apr 8 2021, 9:08 AM
guergana.tzatchkova reopened subtask T279626: Add additional property value relation types to PropertyValueRelation as Open.Apr 8 2021, 10:42 AM
Michael closed subtask T279629: Adjust the SPARQL generation for datatype quantity as Resolved.Apr 9 2021, 10:41 AM
Michael closed subtask T279626: Add additional property value relation types to PropertyValueRelation as Resolved.
Michael moved this task from Ready to pick up to Test (Verification) on the Wikidata Query Builder board.Apr 9 2021, 6:07 PM
Michael subscribed.

This is now ready to be verified on the test-system as well :)

gerritbot added a comment.Apr 9 2021, 6:13 PM

Change 678282 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Ensure day precision for day values

https://gerrit.wikimedia.org/r/678282

gerritbot added a project: Patch-For-Review.Apr 9 2021, 6:13 PM
Michael removed a project: Patch-For-Review.Apr 9 2021, 6:15 PM

That patch doesn't belong to this ticket.

Michael closed subtask T279631: Adjusting the SPARQL generation for datatype date to allow for before and after as Resolved.Apr 12 2021, 8:32 AM
Michael closed subtask T279630: Show new property value relation types in the dropdown for quantity datatypes as Resolved.
• amy_rc closed subtask T268942: (MS 3) query for quantity values as Resolved.Apr 12 2021, 2:53 PM
• amy_rc closed subtask T279627: Show new property value relation types in the dropdown for quantity datatypes as Resolved.Apr 12 2021, 3:10 PM
• amy_rc added a comment.Apr 12 2021, 3:33 PM

Worked for the given BDD,

• amy_rc closed this task as Resolved.Apr 12 2021, 3:48 PM
• amy_rc claimed this task.
• amy_rc moved this task from Test (Verification) to Done on the Wikidata Query Builder board.
• amy_rc closed subtask T272697: (MS 6) Query for date values as Resolved.Apr 13 2021, 10:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL