Page MenuHomePhabricator

Revise New Discussion Tool change tags
Closed, ResolvedPublic

Description

This task is about an adjustment to the change tag [i] that accompanies edits made with the New Discussion Tool.

Thank you to @Patriccck for noticing and saying something about this. [ii]

Adjustment #1

Link the New topic change tag to the New Discussion Tool's project page.

Desired behavior

  1. Visit a page where people have made edits with the New Discussion Tool.
  2. Locate an edit made with the New Discussion Tool.
    • e.g. Ppelberg-test talk contribs‎ 33,200 bytes +173‎ →‎Testing change tag: new section undo Tags: Visual New topic
  3. ✅Notice the New topic tagged is linked to https://www.mediawiki.org/wiki/Special:MyLanguage/Talk_pages_project/New_discussion

Done

  • ===Adjustment 1 is implemented

i. T269486
ii. https://www.mediawiki.org/wiki/Topic:W1yp0cerd0mee0eh

Event Timeline

The first is easy, I'll submit a patch.

The second is trickier:

Apparently there is no way to define the order in which tags should appear. They are ordered according to the ctd_id field, which is generated automatically whenever the tag is used for the first time. Since the reply tool existed first, its tags were used first, and that produces this order: https://quarry.wmflabs.org/query/51848. The order could be different on a different wiki if the new discussion tool was used by someone before the reply tool.

I'll submit a patch that would make it use a pre-defined order instead, but this will affect all of the tags used by any extension – this shouldn't be disruptive, but we should note it somewhere just in case.

Change 658353 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add a link to the project page to the "New topic" change tag

https://gerrit.wikimedia.org/r/658353

Change 658354 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Consistently order tags

https://gerrit.wikimedia.org/r/658354

Change 658353 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add a link to the project page to the "New topic" change tag

https://gerrit.wikimedia.org/r/658353

I made a subtask about the order (T272900).

Noted. I've:

  1. Moved ===Adjustment #2 from this task's description to a new task (T272929) and
  2. Updated T272900 so it references this new task (T272929)
ppelberg updated the task description. (Show Details)