Page MenuHomePhabricator

Enable SandboxLink on viwiki
Closed, ResolvedPublic

Description

Per T72499, this extension should be deploy on viwiki, where a previous gadget used as default (https://vi.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&oldid=63855727, "mySandbox[ResourceLoader|default..."). The extension currently missing, at least with people who already loged in, since it does not show the label "sandbox" in the top menu.

Consensus in 2015 about make this gadget as default.

New consensus about enable SandboxLink.

Event Timeline

minhhuy created this task.Jan 24 2021, 4:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2021, 4:28 AM
minhhuy updated the task description. (Show Details)Jan 24 2021, 4:34 AM
minhhuy added a comment.EditedJan 24 2021, 6:12 AM

Judging from https://vi.wikipedia.org/wiki/Đặc_biệt:Phiên_bản it is not deployed for viwiki

Could we start a request to deploy this for our wiki now? I dont know the reason why the extension isn't get deployed even though the gadget Mysandbox always active as "default" since the first time it imported in to vi.wiki since 2015, there should be a problem of detected which wiki have setup it as default before, and it should be fix now.

Base added a comment.EditedJan 24 2021, 6:33 AM

even though the gadget Mysandbox always active

While the gadget was added in 2014[1], it was made default only in November 2015[2]

The extension was being deployed to the wikis where it was default in April 2015[3], 6 months earlier.

[1] https://vi.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&type=revision&diff=20606134&oldid=20238163
[2] https://vi.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&type=revision&diff=22363487&oldid=22351242
[3] https://phabricator.wikimedia.org/T72499#1195540

Base renamed this task from SandboxLink not available on viwiki to Enable SandboxLink on viwiki.Jan 24 2021, 6:34 AM
minhhuy added a comment.EditedJan 24 2021, 6:39 AM

even though the gadget Mysandbox always active

While the gadget was added in 2014[1], it was made default only in November 2015[2]

The extension was being deployed to the wikis where it was default in April 2015[3], 6 months earlier.

I see. The community made a consensus about active the gadget as default since mid 2015, unfortunately we didnt know about there was an extension is being deploy since April. At least it is activing as default for 5 years with consensus, so the extension should be deploy now.

minhhuy updated the task description. (Show Details)Jan 24 2021, 6:40 AM

I think we can waive the usual requirement of explicit consensus here, considering it already works that way on viwiki. I'll try deploying it tomorrow, through no promises :).

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJan 25 2021, 12:29 AM
Urbanecm changed the subtype of this task from "Bug Report" to "Task".Jan 25 2021, 5:49 AM

Change 658073 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Enable SandboxLink at viwiki

https://gerrit.wikimedia.org/r/658073

Urbanecm moved this task from Backlog to To deploy on the User-Urbanecm board.Jan 25 2021, 5:50 AM

Change 658073 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable SandboxLink at viwiki

https://gerrit.wikimedia.org/r/658073

Change 658266 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "Enable SandboxLink at viwiki"

https://gerrit.wikimedia.org/r/658266

Change 658266 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Enable SandboxLink at viwiki"

https://gerrit.wikimedia.org/r/658266

So, I tried to deploy this, and had to revert. The reason is that the current sandbox gadget links to the public sandbox, rather than user's sandbox, and i failed to see that when preparing the patch. The docs https://www.mediawiki.org/wiki/Extension:SandboxLink doesn't seem to support that usage.

Would viwiki community be willing to change this?

Would viwiki community be willing to change this?

In the consensus, we decided to make the sandbox as subpages of users ("liên kết đến không gian trang con của người dùng."), but somehow (mostly from my mistake while setup the gadget) it remain links to the public sandbox. I do believe the old consensus still applying here, since it should be in that way since the beginning.

Since this actually changes how the sandbox link currently works, I would prefer if you can just ping people at village pump, so this doesn't come as a surprise.

Excellent, please ping me once it finishes :).

Urbanecm triaged this task as Medium priority.Fri, Jan 29, 9:32 PM
minhhuy updated the task description. (Show Details)Fri, Feb 12, 6:09 AM

Change 663736 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "Revert "Enable SandboxLink at viwiki""

https://gerrit.wikimedia.org/r/663736

Change 663736 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Revert "Enable SandboxLink at viwiki""

https://gerrit.wikimedia.org/r/663736

Urbanecm closed this task as Resolved.Mon, Feb 15, 12:13 PM