Page MenuHomePhabricator

Syntaxhighlight block can make floated items unclickable
Closed, ResolvedPublic

Description

Reported by @BrandonXLF on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SyntaxHighlight_GeSHi/+/653609/1#message-b88df1699c057bde874103460ece9321841c2bfc:

This change causes any floating elements beside the syntaxhighlight block to have unclickable portions where the syntaxhighlight block is stacked over the floating element due to the position: relative;. For example, the links in the navbox next to the syntaxhighlight block at https://www.mediawiki.org/wiki/OOUI/Widgets/Icons,_Indicators,_and_Labels are unclickable.

Event Timeline

Esanders created this task.Jan 25 2021, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2021, 2:39 PM

Change 658315 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/658315

T104540 is related to this (100% width containers overlapping floats)

Esanders updated the task description. (Show Details)Jan 25 2021, 2:48 PM

Change 658315 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/658315

Jdforrester-WMF closed this task as Resolved.Jan 25 2021, 10:57 PM
Jdforrester-WMF assigned this task to Esanders.

This is an annoying issue (as evidenced by the duplicates) and the scheduled deployments have been stuck for two weeks now (T271343), so I'm going to backport the fix.

Change 662668 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@wmf/1.36.0-wmf.27] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/662668

Change 662668 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@wmf/1.36.0-wmf.27] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/662668

Mentioned in SAL (#wikimedia-operations) [2021-02-08T13:09:48Z] <ladsgroup@deploy1001> Synchronized php-1.36.0-wmf.27/extensions/SyntaxHighlight_GeSHi/modules/pygments.wrapper.less: [[gerrit:662668|Move position:relative to inner wrapper]] (T272853) (duration: 01m 08s)