Page MenuHomePhabricator

MediaWiki core phpunit coverage job is taking 6+ hours
Closed, DuplicatePublic

Description

@hashar and I briefly discussed this on IRC a few days ago. The coverage job used to complete in under 5 hours, now it's timing out past 6 hours.

Based on the slow test report, my hunch is that the new (see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/20d06b34bbc95bb6f886a03b964f0f3a2239ec36%5E%21/#F31) AutoloaderStructureTest::testAutoloadNoFileScope() is too slow. From the doc block:

	/**
	 * Confirm that all files in $wgAutoloadLocalClasses have no file-scope code
	 * apart from specific exemptions.
	 *
	 * This is slow (~15s). Running it arguably renders all the performance
	 * optimisations above obsolete.
	 *
	 * @dataProvider provideAutoloadNoFileScope
	 */

My hunch that it's much much slower when run under xdebug.

Event Timeline

Legoktm triaged this task as High priority.Jan 25 2021, 9:05 PM
Legoktm created this task.
hashar assigned this task to Daimona.
hashar added a subscriber: Daimona.

The job is https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/ , it indeed used to take a few hours to complete and is now completing in 13 minutes! The reason is @Daimona switched from xdebug to pcov: T234020 :]