Page MenuHomePhabricator

Logged out users get an error instead of a CAPTCHA in DiscussionTools
Closed, ResolvedPublic

Description

Logged out users get an error instead of a CAPTCHA in DiscussionTools. Can be tested on https://patchdemo.wmflabs.org/wikis/5aa8877bb2efcc088403fb3fd5dc23a4/w/index.php/Talk:Main_Page by trying to post any comment. (On Wikimedia wikis, you only get prompted to enter a CAPTCHA if you add an external link in the comment.)

Event Timeline

Change 658454 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix check for null edits

https://gerrit.wikimedia.org/r/658454

(Also fixing the broken localisation message in the last screenshot in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/658456, although it's not related)

ppelberg added a subscriber: ppelberg.

META

...I ask the above wondering: A) "How did I not notice this before?" and B) "What we do differently going forward to detect this kind of issue sooner?"

It's a regression from 1c8ca53c92091b69a073491f4e32e43729e7722e (T268069).

We could refactor how CAPTCHAs are presented in the API, if you'd like us to spend a few weeks on it ;)

(Wipes brow)

We could refactor how CAPTCHAs are presented in the API, if you'd like us to spend a few weeks on it ;)

Nice way to lighten the mood on a Monday, BARTOSZ!

Change 658454 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix check for null edits

https://gerrit.wikimedia.org/r/658454