Logged out users get an error instead of a CAPTCHA in DiscussionTools. Can be tested on https://patchdemo.wmflabs.org/wikis/5aa8877bb2efcc088403fb3fd5dc23a4/w/index.php/Talk:Main_Page by trying to post any comment. (On Wikimedia wikis, you only get prompted to enter a CAPTCHA if you add an external link in the comment.)
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix check for null edits | mediawiki/extensions/DiscussionTools | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T276497 Scale DiscussionTools to all projects | |||
| Open | None | T251207 [Epic] Scale DiscussionTools to all Wikipedias | |||
| Open | None | T233446 [Epic] New Discussion Tool | |||
| Resolved | None | T275256 Make New Topic Tool (desktop) available as opt-out feature at all wikis | |||
| Resolved | • LZaman | T271964 [Release ticket] Make New Discussion Tool available as opt-out feature at partner wikis | |||
| Resolved | matmarex | T272922 Logged out users get an error instead of a CAPTCHA in DiscussionTools |
Event Timeline
Comment Actions
Change 658454 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix check for null edits
Comment Actions
Test wiki created on Patch Demo by Matma Rex using patch(es) linked to this task:
http://patchdemo.wmflabs.org/wikis/1dfcbb1add0c499f15b56dc431fa6ef8/w/
Comment Actions
(Also fixing the broken localisation message in the last screenshot in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/658456, although it's not related)
Comment Actions
META
- @matmarex: is this a regression?
...I ask the above wondering: A) "How did I not notice this before?" and B) "What we do differently going forward to detect this kind of issue sooner?"
Comment Actions
It's a regression from 1c8ca53c92091b69a073491f4e32e43729e7722e (T268069).
We could refactor how CAPTCHAs are presented in the API, if you'd like us to spend a few weeks on it ;)
Comment Actions
(Wipes brow)
We could refactor how CAPTCHAs are presented in the API, if you'd like us to spend a few weeks on it ;)
Nice way to lighten the mood on a Monday, BARTOSZ!
Comment Actions
Change 658454 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix check for null edits