Page MenuHomePhabricator
Create Task
Maniphest T272923

[M] [wmf.27] MediaSearch - duplicate files displayed in search results
Closed, ResolvedPublic
Actions

Description

  1. Perform a search for hamar daban(type or paste the search terms) in Images. When results are displayed - select Medium Image size.

Warning - just pasting the url won't show the bug - https://commons.wikimedia.org/wiki/Special:MediaSearch?type=bitmap&q=hamar+daban&imageSize=500%2C1000

  1. One image (https://commons.wikimedia.org/wiki/File:Bockk%C3%A4fer_Murino.jpg) will be displayed but there will be "No more results found" warning.
  2. Click on the image to see it in the QuickView - the image correctly displayed. Close the QuickView - there will be two identical images displayed.
  3. Click any of the two images to open in QuickView - both images will display the blue outline indicating that they are selected for QuickView. Close the QuickView - there will be three identical images displayed.

Reloading the page will display one image and the warning "No more results found" and the issue won't be reproducible anymore.

The gif below illustrates the following steps

  • entering hamar daban search terms
  • selecting the bug photo for the QuickView (this step is not necessary)
  • selecting a filter Image size - Medium
  • one image is displayed - selecting it for the QuickView triggers duplicate files display

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseMediaInfomaster+18 -7Omit duplicate results
mediawiki/extensions/WikibaseMediaInfomaster+13 -6Prevent searches that are already known to have no results
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Jan 25 2021, 11:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2021, 11:44 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2); removed Structured-Data-Backlog.Jan 26 2021, 3:29 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
CBogen renamed this task from [wmf.27] MediaSearch - duplicate files displayed in search results to [M] [wmf.27] MediaSearch - duplicate files displayed in search results.Feb 9 2021, 5:40 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.
AnneT added a comment.Feb 25 2021, 8:00 PM

Moriel found what might be another instance of this in a larger results set. Query: https://commons.wikimedia.org/wiki/Special:MediaSearch?type=bitmap&q=puppy

Result:

matthiasmullie added a comment.Feb 26 2021, 9:31 AM

I think we have 2 separate problems here:

Elena's original observations is probably caused by the combination of the intersection observer kicking in (after closing quickview reshuffles the contents of the page), and the API call offset param falling back to 0 if it has a falsy value (in this cases, it's null, because there was no offset)

Moriel's observation is probably caused by inconsistencies in search scoring across multiple replicas: scores will have minor deviations across queries, which make it possible for a certain result to rise above or fall below another if their scores are extremely similar. It would probably be best to keep track of what titles are already being rendered, and simply ignore duplicate results coming in.

gerritbot added a comment.Feb 26 2021, 9:51 AM

Change 667125 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Prevent searches that are already known to have no results

https://gerrit.wikimedia.org/r/667125

gerritbot added a project: Patch-For-Review.Feb 26 2021, 9:51 AM

Change 667126 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Omit duplicate results

https://gerrit.wikimedia.org/r/667126

matthiasmullie claimed this task.Feb 26 2021, 9:51 AM
matthiasmullie moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Mar 1 2021, 9:27 PM

Change 667125 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Prevent searches that are already known to have no results

https://gerrit.wikimedia.org/r/667125

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 10:00 PM
AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 3 2021, 3:39 PM
gerritbot added a comment.Mar 4 2021, 12:00 AM

Change 667126 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Omit duplicate results

https://gerrit.wikimedia.org/r/667126

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 12:10 AM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 4 2021, 1:00 AM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Mar 11 2021, 8:41 PM
Etonkovidova updated the task description. (Show Details)Mar 11 2021, 9:50 PM
Etonkovidova closed this task as Resolved.Mar 11 2021, 9:59 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL