Page MenuHomePhabricator

Allow buttons to be full width
Closed, DuplicatePublic

Description

Some buttons in the Query builder UI need to acquire a full-width style when they are displayed in smaller (mobile) viewports.

We should investigate how to allow implementers to apply a full-width style to (L-sized) buttons.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Which buttons? I just made run query and add condition full width. What else is left?

Sorry for not being more specific! There were yet some decisions to be made when I wrote this ticket. I think that those ("Add condition" and "Run query") are the only two buttons that should become full-width is smaller viewports, looking at @Charlie_WMDE's designs.

I believe that you applied a breakpoint of 576px to trigger the full-width, but condition groups acquire their own "full-width" mobile set up from 608px. Maybe we can make the change happen at the same time?

(Let's ignore for now the height of elements, since the system mobile breakpoint still needs revision)

yes, agree. i have made the same comment in the UI improvements ticket

Below 608px some Buttons become full-width now.

Is this task done or is there something left to do?

looks good from my side. will wait for @Sarai-WMDE to close it in case i'm missing smth