Page MenuHomePhabricator

Value type not detected in the visual query after using 'regardless of value'
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Choose instance of property, constraint-matching, then enter human in the value field.
  2. Change the constraint to regardless of value
  3. Then, change it again to without and run the query

`Actual Results: The value field is not recognized.

image.png (598×1 px, 50 KB)

Expected Results:

  • The value field should be emptied when the user switches to "regardless of value".
  • When switching back to "matching" from "regardless of value" the value field is empty.

Event Timeline

Expected Results:
The value field should be recognized and the expected results should be displayed.

Are we sure that this is the expected behavior?

My intuition is rather that the value field should be made empty when "regardless of value" is selected in the dropdown.

I wonder what @Charlie_WMDE thinks 🙂

Can you refresh my memory from the story time? Have we decided to just clean everything once "regardless of value" is selected or we decided to keep it but hide it?

Can you refresh my memory from the story time? Have we decided to just clean everything once "regardless of value" is selected or we decided to keep it but hide it?

Yes, the decision was to drop the value. I think we might already be doing that, we just need to also remove the visual search-string shown in the input. Actually, now that I'm looking at it, it might be that #182 is already touching that.

@bete thanks for the link!

The removal of the value works aka that should solve our problem. I noticed another bug(?) though which i captured in this gif

Peek 2021-02-15 16-31.gif (700×1 px, 409 KB)

but i guess that's for another ticket.