Page MenuHomePhabricator

Enable DiscussionTools page transformations (DOM modification) for all users
Open, Needs TriagePublic

Description

We are now able to put the page transformations in the parser cache (T267404), and also selective enable them using CSS/JS (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/647587).

Going forward we expect (1) more users to have the feature enabled by default, and (2) we will be building features that require page transformations even for users that don't have the tools enabled, for example linking to specific comments in a notification (T263820 + T253082).

At this point it won't make sense to keep generating two versions of the page, and we should just apply our transformations to all talk pages.

Deployment timing

  • Assuming no issues emerge from T267404, these patches can be gradually merged to more wikis.

Open question

  • When do we think this work should be merged? What – if any – specific testing should be done to ensure it's working as expected?
  • Assuming no issues emerge from T267404, these patches can be gradually merged to more wikis.
    • Note: @Esanders is monitoring whether T267404 produces any performance issues.

Testing instructions

TBD

Event Timeline

ppelberg added a subscriber: ppelberg.

Notes from @esdanders on timing/sequencing

  • Ideally, we will work on/deploy this after the Reply Tool is available, by default, on more Wikipedias.
    • Thinking: having the tool deployed more widely will give us valuable information about performance that could inform the approach we take here.

Change 659960 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Add body class to enable reply links

https://gerrit.wikimedia.org/r/659960

Change 663223 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Only show reply links when body class in present

https://gerrit.wikimedia.org/r/663223

META
Updated the task description with what we talked about in our team meeting on 3-Feb.

Change 659960 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add body class to enable reply links

https://gerrit.wikimedia.org/r/659960

The above patch makes this possible but does not enable the page transformations everywhere as this task describes. That will happen later once we're happy with the initial rollout of the ParserCache feature.

Change 663223 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Only show reply links when body class in present

https://gerrit.wikimedia.org/r/663223

Given that we are happy that most people who receive a topic notification will already have the page transformations enabled, this is not a priority for now.

Given that we are happy that most people who receive a topic notification will already have the page transformations enabled, this is not a priority for now.

Moving to the backlog per the above.