Page MenuHomePhabricator
Create Task
Maniphest T273123

Validate user-defined types which are simple compositions of pre-defined types
Closed, ResolvedPublic
Actions

Description

When a type is a composition of well-known types, we can validate this composition based on the existing validators of the parts.

This won't allow us full validation, e.g. to ensure that the type positive integer only consists of digits, but it will allow us to validate a larger number of tasks.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Support validation of user-defined types within orchestrator.mediawiki/services/function-orchestratormaster+279 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

DVrandecic created this task.Jan 27 2021, 10:36 PM
DVrandecic added a parent task: T260861: Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded .Jan 27 2021, 10:47 PM
DVrandecic added a subtask: T273122: Split validation paths for well-known types from user defined types.
Jdforrester-WMF subscribed.Jan 30 2021, 1:21 AM

This is blocked on composition of functions, right?

DVrandecic closed subtask T273122: Split validation paths for well-known types from user defined types as Resolved.Feb 3 2021, 5:16 PM
DVrandecic moved this task from To Triage to Phase ε on the Abstract Wikipedia team board.Feb 3 2021, 5:21 PM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase ε); removed: Abstract Wikipedia team.
DVrandecic moved this task from Phase ε to Phase ζ on the Abstract Wikipedia team board.Mar 10 2021, 12:52 AM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase ζ); removed: Abstract Wikipedia team (Phase ε).
DVrandecic moved this task from Phase ζ to Phase η – Generic types on the Abstract Wikipedia team board.Jun 2 2021, 4:35 PM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase η – Generic types); removed: Abstract Wikipedia team (Phase ζ).
DVrandecic renamed this task from Validate composed types to Validate user-defined types.Sep 22 2021, 4:49 PM
DVrandecic triaged this task as Medium priority.Oct 6 2021, 4:24 PM
Jdforrester-WMF renamed this task from Validate user-defined types to Validate user-defined types which are simple compositions of pre-defined types.Oct 20 2021, 10:50 PM
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 3 2021, 4:38 PM
gerritbot added a comment.Dec 20 2021, 7:06 PM

Change 747862 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Support validation of user-defined types within orchestrator.

https://gerrit.wikimedia.org/r/747862

gerritbot added a project: Patch-For-Review.Dec 20 2021, 7:06 PM
gerritbot added a comment.Dec 21 2021, 10:03 AM

Change 747862 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Support validation of user-defined types within orchestrator.

https://gerrit.wikimedia.org/r/747862

Jdforrester-WMF mentioned this in rMSFO6e904489ab22: Support validation of user-defined types within orchestrator..Dec 21 2021, 10:04 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 21 2021, 10:10 AM
Jdforrester-WMF assigned this task to cmassaro.Dec 21 2021, 6:53 PM
Jdforrester-WMF moved this task from Ready to do to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.
DVrandecic closed this task as Resolved.Jan 11 2022, 5:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits