Page MenuHomePhabricator

After portlet contents should be part of the dropdown menu - add links is not accessible
Closed, ResolvedPublic2 Estimated Story Points

Description

On https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators the language button renders like so:

Screen Shot 2021-01-27 at 5.17.12 PM.png (146×482 px, 14 KB)

The add links link is not accessible as despite being part of the menu, is not part of the dropdown menu.

One potential solution is to revise the styles so that the add links item appears at the bottom of the list when selected although this may require HTML changes since the menu currently relies on absolute positioning.

  1. QA steps
  2. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators and confirm the edit links link is not visible
  3. Click the language button to confirm the edit links button displays and is clickable

Developer notes

Replicate this behavior with:

$wgHooks['SkinAfterPortlet'][] = function ( $skin, $portlet, &$html ) {
	if($portlet === 'lang') {
		$html.= '<span class="wb-langlinks-edit wb-langlinks-link" style="line-height: 1.125em;font-size: 0.75em;float: right;list-style: none none;text-align: right;padding-right: 0.5em !important;"><a href="#" style="color: #54595d !important;filter: grayscale(1);opacity: 0.73;">Edit linkS</a></span>';
	}
};

QA Results - Beta

ACStatusDetails
1T273143#6803753
2T273143#6803753

QA Results - Prod

ACStatusDetails
1T273143#6842537
2T273143#6842537

Event Timeline

Change 659440 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] After portlet is included in display of menu dropdown

https://gerrit.wikimedia.org/r/659440

Change 659440 merged by jenkins-bot:
[mediawiki/skins/Vector@master] After portlet is included in display of menu dropdown

https://gerrit.wikimedia.org/r/659440

ovasileva set the point value for this task to 2.Feb 1 2021, 6:22 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators and confirm the edit links link is not visible

Screen Shot 2021-02-04 at 6.19.16 AM.png (363×307 px, 11 KB)

✅ AC2: Click the language button to confirm the edit links button displays and is clickable

Screen Shot 2021-02-04 at 6.19.26 AM.png (363×307 px, 16 KB)

https://gerrit.wikimedia.org/r/659440 appears to have broken the hover state for Vector dropdown menus. For example at https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators I must click on the "More" menu at the top-right for it to show (if you don't see the More menu, try running e.g. mw.util.addPortletLink('p-cactions', '#', 'Foo'); ).

I think this should be fixed before wmf.29 advances to any more wikis.

Change 662787 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/Vector@master] Bring back hoverability on dropdown menu (e.g. "More" tab)

https://gerrit.wikimedia.org/r/662787

Change 662787 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Bring back hoverability of dropdown menu (e.g. "More" tab)

https://gerrit.wikimedia.org/r/662787

Edtadros subscribed.

As discussed in standup, this will be validated in production with the main task.