Maniphest T273152

Phan should detect invalid constant access
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Tgr
	Jan 28 2021, 7:17 AM

Tags

Referenced Files

None

Subscribers

Description

T273099: Undefined class constant 'BASE_CSS_CLASS' is a fairly straightforward constant visibility error: BaseModule::BASE_CSS_CLASS is a private constant but a subclass references it. It was caused by rEGREfc1dbe3afd65: Fix PSR12.Properties.ConstantVisibility.NotFound. This should be trivial to detect during static analysis but phan missed it.

Related Objects

Mentioned Here: T289751: Update from Phan 3 to Phan 4 (or Phan 5)
T273099: Undefined class constant 'BASE_CSS_CLASS'
rEGREfc1dbe3afd65: Fix PSR12.Properties.ConstantVisibility.NotFound

Event Timeline

Tgr created this task.Jan 28 2021, 7:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2021, 7:17 AM

https://github.com/phan/phan/issues/4360

The upstream issue was resolved in January - has our version of phan been updated, and can this be closed?

In T273152#7135995, @DannyS712 wrote:

The upstream issue was resolved in January - has our version of phan been updated, and can this be closed?

No. We're still using 3.2.6, but the fix was included in 4.0.3.

A new version of the config package is now available - T289751