Page MenuHomePhabricator

[S] Some files don't show license information in QuickView
Closed, ResolvedPublic

Description

No attribution is shown for files that do have licensing information.
The following file has Licensing attribution but it's not shown in QuickView.

Screen Shot 2021-01-13 at 5.18.41 PM.png (678×879 px, 785 KB)
Screen Shot 2021-01-13 at 5.19.02 PM.png (1,513×1,217 px, 1 MB)

The cause for there being no license information is that UsageTerms is missing from the extmetadata response.
There is, however, a LicenseShortName key, which may be a good enough substiture when UsageTerms is missing?

Acceptance criteria:

Event Timeline

CBogen renamed this task from Some files don't show license information in QuickView to [S] Some files don't show license information in QuickView.Feb 9 2021, 5:43 PM
CBogen updated the task description. (Show Details)

Change 672551 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Fall back on LicenseShortName when UsageTerms is not available

https://gerrit.wikimedia.org/r/672551

I don't know all the possible values that Commons users may have added for LicenseShortName, but it seems like attribution and No restrictions are common here. This search (which includes the file mentioned above) includes both examples.

For the purposes of icons, I'm treating attribution as CC icon and No restrictions as public domain (unlocked lock) icon.

Change 672551 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fall back on LicenseShortName when UsageTerms is not available

https://gerrit.wikimedia.org/r/672551

Etonkovidova subscribed.

This issue is not present on commons wmf.36

Screen Shot 2021-03-24 at 3.01.12 PM.png (827×707 px, 832 KB)