Page MenuHomePhabricator

Remove unused config options VisualEditorNewAccountEnableProportion and VisualEditorAutoAccountEnable
Open, Needs TriagePublic

Description

While working on T271434, and trying to understand all of the places where the 'visualeditor-enable' user option is used in the code, I found that we have lots of code to support the config options VisualEditorNewAccountEnableProportion and VisualEditorAutoAccountEnable.

They are not currently used on Wikimedia wikis, and as far as I can tell they have never been used. They were added around 2015.

We should remove them and all the code that supports them.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2021, 11:37 AM

CC @Jdforrester-WMF in case you have some historical context to add.

I found:

Change 659299 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Remove unused config options VisualEditorNewAccountEnableProportion and VisualEditorAutoAccountEnable

https://gerrit.wikimedia.org/r/659299

Jdforrester-WMF added a comment.EditedWed, Feb 10, 9:12 PM

These configs were created and very much used for the rollout (see for instance rOMWCe490eb84f298: Enable VisualEditor for 10% of new accounts on eswiki and then rOMWCfdc25a069940: Drop already-enabled VisualEditorNewAccountEnableProportion wikis), which is still incomplete. I don't know what the Editing team's plans are for rolling out the editor to additional wikis like zhwiki or enwikibooks or whatever, but I presume you don't think that's likely to happen soon. :-)

Change 659299 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove two unused configuration options

https://gerrit.wikimedia.org/r/659299

Change 663699 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Remove uses of removed VisualEditor config variables (1/2)

https://gerrit.wikimedia.org/r/663699

Change 663700 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Remove uses of removed VisualEditor config variables (2/2)

https://gerrit.wikimedia.org/r/663700

Change 663699 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove uses of removed VisualEditor config variables (1/2)

https://gerrit.wikimedia.org/r/663699

Change 663700 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove uses of removed VisualEditor config variables (2/2)

https://gerrit.wikimedia.org/r/663700

Mentioned in SAL (#wikimedia-operations) [2021-02-17T19:06:51Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 6ac78bd2aa601db537f821c89b447c04927af422: Remove uses of removed VisualEditor config variables (T273177; 1/2) (duration: 01m 14s)

Mentioned in SAL (#wikimedia-operations) [2021-02-17T19:08:23Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 6ac78bd2aa601db537f821c89b447c04927af422: Remove uses of removed VisualEditor config variables (T273177; 2/2) (duration: 01m 07s)

ppelberg closed this task as Resolved.Sat, Feb 20, 3:20 AM
ppelberg reopened this task as Open.
ppelberg claimed this task.

@matmarex, building on what @Jdforrester-WMF shared in T273177#6820398, does removing this code in any way limit our ability to make VE more widely available at some yet-to-be defined point in the future?

No, it does not. The removed code allowed us to change the default value of the 'visualeditor-enable' preference for new users, without changing it for existing users. However, we do not actually use that preference for rolling out VE these days (it has been re-used for the beta feature, and I don't think we'd ever want to enable a beta feature by default…).