Page MenuHomePhabricator

Contradictory (or duplicate) user preferences for enabling/disabling VE
Closed, ResolvedPublic

Description

Depending on the config, VisualEditor can define contradictory user preferences for enabling/disabling it:

  • When the BetaFeatures extension is not installed, there are two preferences under Editing: "Enable the visual editor (…)" and "Temporarily disable the visual editor (…)"
  • When the BetaFeatures extension is installed, and $wgVisualEditorEnableBetaFeature is set to true, there is the beta feature preference "Visual editing" and an additional preference under Editing: "Temporarily disable the visual editor (…)"

Expected behavior:

  • When the BetaFeatures extension is installed, and $wgVisualEditorEnableBetaFeature is set to true, only the beta feature preference should appear
  • Otherwise, only the "Temporarily disable the visual editor (…)" preference should appear

This bug actually affects Wikimedia wikis, but we have a workaround for this problem: the extraneous preference is hidden using $wgHiddenPrefs.

Event Timeline

Change 659300 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Do not define contradictory user preferences for enabling/disabling VE

https://gerrit.wikimedia.org/r/659300

Change 659300 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Do not define contradictory user preferences for enabling/disabling VE

https://gerrit.wikimedia.org/r/659300

Change 663701 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Remove unneeded $wgHiddenPrefs[] = 'visualeditor-betatempdisable'

https://gerrit.wikimedia.org/r/663701

Change 663701 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove unneeded $wgHiddenPrefs[] = 'visualeditor-betatempdisable'

https://gerrit.wikimedia.org/r/663701

Mentioned in SAL (#wikimedia-operations) [2021-02-24T19:14:24Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: f9f968ac7043d2b52cac91dbfaab7e4077b04230: Remove unneeded $wgHiddenPrefs[] = visualeditor-betatempdisable (T273188) (duration: 01m 04s)

(not testable on Wikimedia wikis, since we've always used configuration variables that worked around the bug)