Preference "Editing mode" always appears on single-edit-tab wikis where VisualEditor is a beta feature
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jan 28 2021, 3:10 PM

Description

Preference "Editing mode" always appears on single-edit-tab wikis where VisualEditor is a beta feature (for example, English Wiktionary: https://en.wiktionary.org/).

It should only appear for users who enable the VisualEditor beta feature, as changing it it has no effect otherwise (because the source editor is the only available editing mode).

Details

	Subject	Repo	Branch	Lines +/-
	Only show "Editing mode" preference when VE enabled (on SET beta-feature wikis)	mediawiki/extensions/VisualEditor	master	+2 -4
	Stop showing the "Editing tabs" popup some time after SET switch	mediawiki/extensions/VisualEditor	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T130021: "Editing tabs" dialog (SET first-time information) is too small for translated button labels to fit
T271434: VisualEditor does not show up after (re)enabling it via normal preference, when VE is a beta feature and had been set to disabled in global preferences
Mentioned Here: T271434: VisualEditor does not show up after (re)enabling it via normal preference, when VE is a beta feature and had been set to disabled in global preferences

Event Timeline

matmarex created this task.Jan 28 2021, 3:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2021, 3:10 PM

(I noticed this bug in the code – the beta-feature and not-beta-feature mode were handled inconsistently – when working on T271434, and then tried to find a combination of config options that would make this inconsistency obvious. Turns out this bug has a visible effect in production.)

There's a second issue: the same bug caused users on those wikis to never get the prompt about editing tabs when those wikis were switched to single-edit-tab mode (screenshot below). If we fix it, then anyone who has the beta feature enabled and who has edited before the single-edit-tab mode was enabled (2016-ish) will see that prompt the next time they open the editor. Hopefully that won't be too annoying…

Change 659302 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Only show "Editing mode" preference when VE enabled (on SET beta-feature wikis)

https://gerrit.wikimedia.org/r/659302

gerritbot added a project: Patch-For-Review.Jan 28 2021, 3:53 PM

matmarex mentioned this in T271434: VisualEditor does not show up after (re)enabling it via normal preference, when VE is a beta feature and had been set to disabled in global preferences.Jan 28 2021, 3:57 PM

Notes from conversation with Bartosz
We came to wonder...

What would be involved in separating the Preference "Editing mode" issue from the Editing tabs welcome dialog T273189#6784039?
Along what dimensions we might be able to more specifically target who would potentially see the Editing tabs dialog? E.g. people who have edited before 2016 and have not edited in the past 2 years or something.

Note: as this patch is currently written, people who have edited before 2016 and have the visual editor enabled would see the Editing tabs dialog upon opening any editing interface at any point after this patch would be released.

see the Editing tabs dialog:

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jan 28 2021, 4:21 PM

matmarex added a project: Editing-team (Kanban Board).

Change 661447 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Stop showing the "Editing tabs" popup some time after SET switch

https://gerrit.wikimedia.org/r/661447

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Feb 3 2021, 7:49 PM

It's probably no longer helpful to show people a popup dialog about a change that happened 5 years ago. We should just stop showing it.

Change 661447 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Stop showing the "Editing tabs" popup some time after SET switch

https://gerrit.wikimedia.org/r/661447

Change 659302 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Only show "Editing mode" preference when VE enabled (on SET beta-feature wikis)

https://gerrit.wikimedia.org/r/659302

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 12 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2021, 6:10 PM

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 12 2021, 8:24 PM

matmarex added a project: Skipped QA.

• ppelberg closed this task as Resolved.Mar 3 2021, 3:26 AM

• ppelberg claimed this task.

matmarex mentioned this in T130021: "Editing tabs" dialog (SET first-time information) is too small for translated button labels to fit.Jun 29 2022, 6:50 PM