Page MenuHomePhabricator

defaultView:ImageGrid does not wrap well on Firefox
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT

Description

Steps to Reproduce:

  • Open the Query Service on Firefox. I used 84.0.2 (64-bit) Mozilla Firefox for Ubuntu canonica - 1.0
  • Run this query: https://w.wiki/8NoG

Actual Results:
The images are not stacked to fit the width of the page, creating some awkward alignment:

image.png (874×1 px, 921 KB)

Expected Results:
The images should be resized and wrapped to fit the page width. This is happening in the Chromium browser:

Screenshot from 2023-12-04 16-57-23.png (1×1 px, 1 MB)

Event Timeline

I can reproduce with Firefox 105.0.1.

It seems that the last image of a row is sent to the next line.

According the the replies to this tweet (where a screenshot of the issue is visible), several users are affected.

Arian_Bozorg set the point value for this task to 5.Feb 20 2024, 9:25 AM

Change 1008453 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[wikidata/query/gui@master] Fix defaultView:ImageGrid does not wrap well on Firefox

https://gerrit.wikimedia.org/r/1008453

Change 1008453 merged by jenkins-bot:

[wikidata/query/gui@master] Fix defaultView:ImageGrid does not wrap well on Firefox

https://gerrit.wikimedia.org/r/1008453

Arian_Bozorg subscribed.

I am still experiencing the same issue on Firefox unfortunately

image.png (1×1 px, 900 KB)

It is unclear to me whether the patch has gone into production, but as @Arian_Bozorg I also still experience the problem.

It's now deployed on production, you can test it again @Arian_Bozorg