Page MenuHomePhabricator
Create Task
Maniphest T273232

Clicking the language button should load Universal Language Selector
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jan 28 2021, 9:49 PM
Tags
Referenced Files
F34105085: Screen Recording 2021-02-14 at 1.25.18 PM.mov.gif
Feb 14 2021, 9:30 PM
F34105087: Screen Recording 2021-02-14 at 1.27.24 PM.mov.gif
Feb 14 2021, 9:30 PM
F34105076: Screen Recording 2021-02-14 at 1.16.48 PM.mov.gif
Feb 14 2021, 9:30 PM
F34105082: Screen Recording 2021-02-14 at 1.21.37 PM.mov.gif
Feb 14 2021, 9:30 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
• nray
ovasileva

Description

Following up to T260738, clicking the language button with JavaScript enabled should load the universal language selector dialog.

UniversalLanguageSelector will enhance an existing button with the mw-interlanguage-selector class.

Acceptance criteria

  • The class mw-interlanguage-selector class is added to the button.
  • When ULS enhances the button, the hover effect should be disabled.

Notes

We may need to check the existence/state of the ULS module and use client-js to determine whether to disable the ULS hover effect.

QA steps

Details

SubjectRepoBranchLines +/-
Fire hook when user clicks language buttonmediawiki/extensions/UniversalLanguageSelectormaster+2 -0
Modern Vector should be compatible with ULSmediawiki/extensions/UniversalLanguageSelectormaster+11 -8
Add mw-interlanguage-selector class to language button & hide menu/arrow when appropriatemediawiki/skins/Vectormaster+59 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 28 2021, 9:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2021, 9:49 PM
ovasileva triaged this task as High priority.Feb 1 2021, 6:06 PM
ovasileva set the point value for this task to 3.Feb 1 2021, 6:28 PM
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• nray claimed this task.Feb 1 2021, 7:03 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a comment.Feb 1 2021, 10:07 PM

@nray https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/635080 may be interesting reading prior to taking this on. I did try out a few things there.
,

• nray added a comment.Feb 1 2021, 10:35 PM

thanks @Jdlrobson !

gerritbot added a comment.Feb 4 2021, 9:09 PM

Change 661804 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/Vector@master] POC: Add mw-interlanguage-selector class to language button & hide menu

https://gerrit.wikimedia.org/r/661804

gerritbot added a project: Patch-For-Review.Feb 4 2021, 9:09 PM
• nray removed • nray as the assignee of this task.Feb 5 2021, 12:58 AM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• nray subscribed.
• nray claimed this task.Feb 5 2021, 5:45 PM
• nray moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• nray reassigned this task from • nray to Jdlrobson.Feb 5 2021, 9:30 PM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 5 2021, 9:47 PM
Jdlrobson reassigned this task from Jdlrobson to ovasileva.Feb 5 2021, 9:49 PM

The new button has 2 problems

  1. The label changes on pages without languages
  2. When the button is clicked no languages are showing due to a now invalid assumption in the UniversalLanguageSelector about where to find languages.

I've posted https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/661797 but we'll need to coordinate with the language team to get that merged.

The cog is currently hidden, but we're discussing that separately.

gerritbot added a comment.Feb 5 2021, 9:50 PM

Change 661797 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] Modern Vector should be compatible with ULS

https://gerrit.wikimedia.org/r/661797

gerritbot added a comment.Feb 5 2021, 11:22 PM

Change 661804 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add mw-interlanguage-selector class to language button & hide menu/arrow when appropriate

https://gerrit.wikimedia.org/r/661804

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 6 2021, 12:00 AM
gerritbot added a comment.Feb 9 2021, 6:07 PM

Change 661797 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Modern Vector should be compatible with ULS

https://gerrit.wikimedia.org/r/661797

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2021, 6:10 PM
Jdlrobson reassigned this task from ovasileva to Edtadros.Feb 9 2021, 6:17 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a subscriber: ovasileva.
Jdlrobson updated the task description. (Show Details)Feb 9 2021, 11:04 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Feb 14 2021, 9:30 PM
Edtadros subscribed.

Test Result - Beta{F34105087

Status: ❓
Environment: beta
OS: macOS Big Sur
Browser: Chrome, Firefox, Safari, Edge
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators and confirm you can switch to all 7 available languages

ChromeFirefoxSafariEdge
Screen Recording 2021-02-14 at 1.16.48 PM.mov.gif (850×902 px, 2 MB)
Screen Recording 2021-02-14 at 1.21.37 PM.mov.gif (850×902 px, 1 MB)
Screen Recording 2021-02-14 at 1.25.18 PM.mov.gif (850×902 px, 1 MB)

Check Firefox, Chrome, Safari, Edge (this can be deferred if a general QA of the feature later is being planned).
See Above.

@Jdlrobson The navigation works, but the target page shows 0 languages. Is that functioning as expected?

Jdlrobson removed Jdlrobson as the assignee of this task.Feb 18 2021, 6:10 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

@Jdlrobson The navigation works, but the target page shows 0 languages. Is that functioning as expected?

That's fine.

ovasileva closed this task as Resolved.Feb 19 2021, 10:50 AM
ovasileva claimed this task.
gerritbot added a comment.May 4 2021, 4:16 PM

Change 684984 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/UniversalLanguageSelector@master] Fire hook when opened via language button

https://gerrit.wikimedia.org/r/684984

gerritbot added a project: Patch-For-Review.May 4 2021, 4:16 PM
gerritbot added a comment.May 10 2021, 11:00 AM

Change 684984 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/UniversalLanguageSelector@master] Fire hook when user clicks language button

https://gerrit.wikimedia.org/r/684984

gerritbot added a comment.May 10 2021, 8:46 PM

Change 684984 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Fire hook when user clicks language button

https://gerrit.wikimedia.org/r/684984

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL