Page MenuHomePhabricator
Create Task
Maniphest T273243

[wmf.28-regression] frwiktionary - SE module displayed on Homepage with errors
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
• Urbanecm_WMF
Authored By
Etonkovidova
Jan 28 2021, 11:02 PM
Tags
Referenced Files
F34083498: image.png
Feb 1 2021, 7:08 PM
F34056236: Screen Shot 2021-01-28 at 3.01.57 PM.png
Jan 28 2021, 11:02 PM
F34056218: Screen Shot 2021-01-28 at 2.23.40 PM.png
Jan 28 2021, 11:02 PM
F34056213: Screen Shot 2021-01-28 at 2.23.22 PM.png
Jan 28 2021, 11:02 PM
Subscribers
Aklapper
Etonkovidova
kostajh
• mewoph
MMiller_WMF
Tgr
Trizek-WMF

Description

Steps to Reproduce:

  1. Log in frwiktionary and enable Homepage in Special:Preferences.
  2. Go to Special:Homepage (click on a username in the personal toolbar)
  3. The SE intro tour will be displayed with some options disabled.

Actual Results:

Screen Shot 2021-01-28 at 2.23.22 PM.png (644×677 px, 91 KB)
Screen Shot 2021-01-28 at 2.23.40 PM.png (651×685 px, 95 KB)
Screen Shot 2021-01-28 at 3.01.57 PM.png (666×655 px, 91 KB)

The console will display

Cannot read property 'html' of undefined TypeError: Cannot read property 'html' of undefined
  at StartEditingDialog.setupSuggestedEditsModule
  1. Reload the page - the SE module will be gone.

Expected Results:
frwiktionary is not supposed to have SE module activated.

Details

SubjectRepoBranchLines +/-
SpecialHomepage: Do not load start-startediting if SE aren't enabledmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.27+4 -2
SpecialHomepage: Do not load start-startediting if SE aren't enabledmediawiki/extensions/GrowthExperimentsmaster+4 -2
SpecialHomepage: Do not load start-startediting if SE aren't enabledmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.28+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 28 2021, 11:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2021, 11:02 PM
Trizek-WMF subscribed.Feb 1 2021, 6:30 PM
• Urbanecm_WMF claimed this task.Feb 1 2021, 6:34 PM
Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptFeb 1 2021, 6:34 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 1 2021, 6:56 PM

@Urbanecm_WMF is going to work on this.

gerritbot added a comment.Feb 1 2021, 6:57 PM

Change 660875 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] SpecialHomepage: Do not load start-startediting if SE aren't enabled

https://gerrit.wikimedia.org/r/660875

gerritbot added a project: Patch-For-Review.Feb 1 2021, 6:57 PM
• Urbanecm_WMF moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 1 2021, 6:58 PM
• Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.
• Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.
• Urbanecm_WMF added a comment.Feb 1 2021, 7:08 PM

Does anyone have a screenshot of frwiktionary homepage pre-regression?

After I make it not to render the onboarding module (start-startediting) via the patch above, it looks like this:

image.png (788×1 px, 56 KB)

which...doesn't look like something we want.

gerritbot added a comment.Feb 1 2021, 7:25 PM

Change 660928 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.28] SpecialHomepage: Do not load start-startediting if SE aren't enabled

https://gerrit.wikimedia.org/r/660928

• Urbanecm_WMF added a comment.Feb 1 2021, 7:25 PM
In T273243#6793464, @Urbanecm_WMF wrote:

Does anyone have a screenshot of frwiktionary homepage pre-regression?

After I make it not to render the onboarding module (start-startediting) via the patch above, it looks like this:

image.png (788×1 px, 56 KB)

which...doesn't look like something we want.

Kosta confirmed to me via IRC that this is correct. CR'ed by Kosta => will backport shortly.

gerritbot added a comment.Feb 1 2021, 7:38 PM

Change 660928 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.28] SpecialHomepage: Do not load start-startediting if SE aren't enabled

https://gerrit.wikimedia.org/r/660928

Stashbot added a comment.Feb 1 2021, 7:41 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-01T19:41:49Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.28/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php: rEGRE1acaba4b3650: SpecialHomepage: Do not load start-startediting if SE arent enabled (T273243) (duration: 01m 05s)

gerritbot added a comment.Feb 1 2021, 7:43 PM

Change 660875 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SpecialHomepage: Do not load start-startediting if SE aren't enabled

https://gerrit.wikimedia.org/r/660875

• Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 1 2021, 7:44 PM

Fix was deployed seconds ago.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Feb 1 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2021, 8:10 PM
gerritbot added a comment.Feb 2 2021, 7:14 AM

Change 660937 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.27] SpecialHomepage: Do not load start-startediting if SE aren't enabled

https://gerrit.wikimedia.org/r/660937

gerritbot added a project: Patch-For-Review.Feb 2 2021, 7:14 AM
gerritbot added a comment.Feb 2 2021, 12:15 PM

Change 660937 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.27] SpecialHomepage: Do not load start-startediting if SE aren't enabled

https://gerrit.wikimedia.org/r/660937

Stashbot added a comment.Feb 2 2021, 12:18 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-02T12:18:52Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.27/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php: rEGRE18c59d018b6e: SpecialHomepage: Do not load start-startediting if SE arent enabled (T273243) (duration: 01m 01s)

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2021, 1:10 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Feb 2 2021, 2:00 PM
Etonkovidova closed this task as Resolved.Feb 3 2021, 1:47 AM

Checked on frwiktionary wmf.27- works as expected now.

• Urbanecm_WMF mentioned this in T280736: frwiktionary: suggested edits code unintentionally runs: GrowthExperiments\WikiConfigException: The configuration title does not exist.Apr 20 2021, 8:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits