Page MenuHomePhabricator

Create in line replies
Closed, ResolvedPublic

Description

As an Android App TalkPages user,
I want to reply directly to someone within an ongoing conversation
and see the reply inline

Example of this can be found on Beta from the Editing team's Talk Pages project.

Event Timeline

LGoto triaged this task as Low priority.Feb 1 2021, 5:13 PM
LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.

@JTannerWMF
Do you know who can I ping for a question regarding the API they are using on the beta page? Just curious about do they have an API of appending text on a specific line in a section or they just use the action=edit with a combined wikitext.

cooltey added a subscriber: sdkim.

cc @JTannerWMF @sdkim

Looks like on the Beta page, each comment contains a commentid, and the commentid will be used in the action=discussiontoolsedit to submit an inline reply message.

<span data-mw-comment-start="c|173.76.103.59|2021-02-17T17:25:00.000Z|24.7.23.207|2021-02-10T22:37:00.000Z"></span>

The page/talk API does not contain the commentid in every reply, which means we may need the #product-infrastructure-team-backlog team to update the API.

commentids are generated by the comment parser, a piece of code that lives in the DiscussionTools extension (and is implemented twice in PHP and JS). Currently the content APIs will not return content with these IDs as we add them with a page hook.

commentids are generated by the comment parser, a piece of code that lives in the DiscussionTools extension (and is implemented twice in PHP and JS). Currently the content APIs will not return content with these IDs as we add them with a page hook.

Thanks, @Esanders. Do you think it will have an API of it by the time when the DiscussionTools is in the production? We would like to see the timeline of it so that we can introduce this feature in the app too.

commentids are generated by the comment parser, a piece of code that lives in the DiscussionTools extension (and is implemented twice in PHP and JS). Currently the content APIs will not return content with these IDs as we add them with a page hook.

Thanks, @Esanders. Do you think it will have an API of it by the time when the DiscussionTools is in the production? We would like to see the timeline of it so that we can introduce this feature in the app too.

@cooltey, I think this would be a good question to raise with @sdkim (here or offline).

Last he and I talked about it, the Platform Engineering was going to prioritize the prospect of generalizing the API we've built for DiscussionTools against other API requests the Platform Team has gotten for this next fiscal year.


Note: I wonder if y'all would find value in this help page @matmarex created that describes DiscussionTools' internals: https://www.mediawiki.org/wiki/Extension:DiscussionTools/How_it_works.

commentids are generated by the comment parser, a piece of code that lives in the DiscussionTools extension (and is implemented twice in PHP and JS). Currently the content APIs will not return content with these IDs as we add them with a page hook.

Thanks, @Esanders. Do you think it will have an API of it by the time when the DiscussionTools is in the production? We would like to see the timeline of it so that we can introduce this feature in the app too.

@cooltey, I think this would be a good question to raise with @sdkim (here or offline).

Last he and I talked about it, the Platform Engineering was going to prioritize the prospect of generalizing the API we've built for DiscussionTools against other API requests the Platform Team has gotten for this next fiscal year.


Note: I wonder if y'all would find value in this help page @matmarex created that describes DiscussionTools' internals: https://www.mediawiki.org/wiki/Extension:DiscussionTools/How_it_works.

hi @cooltey – slight deviation from the guidance I shared above and a resulting question for you...

Can you please populate T285971 with the functionality/behavior the Android Team needs from the Talk API in order to deliver the in-line reply experience y'all have in mind?

I recognize you started to articulate this in T273292#6839607, although having this information centralized in one ticket will help @sdkim and I figure out how the changes y'all are requesting will get implemented.

Hi @ppelberg,

Thanks for the update and for creating the ticket. I will discuss this with our engineers and update ticket T285971 soon.

Hi @ppelberg,

Thanks for the update and for creating the ticket. I will discuss this with our engineers and update ticket T285971 soon.

Sounds great and you bet.