Schema change for dropping default of img_timestamp and making it binary(14)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Jan 30 2021, 12:47 PM

Details

	Subject	Repo	Branch	Lines +/-
	db1121,db1155,clouddb*s4: Disable notifications	operations/puppet	production	+5 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	Legoktm	T281515 June 2021 Datacenter switchover
Resolved	Marostegui	T285139 DB maintenance work to do while eqiad is passive (June 2021)
Resolved	Marostegui	T273360 Schema change for dropping default of img_timestamp and making it binary(14)
Resolved	• Kormat	T283131 Upgrade s3 to Debian Buster and MariaDB 10.4
Resolved	• Kormat	T284648 Switchover s3 from db1123 to db1157
Resolved	Trizek-WMF	T284650 Read-only window needed for s3 (~900 wikis)
Resolved	Marostegui	T283235 Upgrade s5 to Debian Buster and MariaDB 10.4
Resolved	Marostegui	T284529 Switchover s5 from db1100 to db1130
Resolved	sgrabarczuk	T284530 Read only time window needed for s5

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Ladsgroup renamed this task from Schema change for dropping default of img_timestamp to Schema change for dropping default of img_timestamp and making it binary(14).Mar 1 2021, 7:55 PM

Ladsgroup updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Mar 2 2021, 5:31 AM

Marostegui added a project: DBA.

Marostegui moved this task from Triage to Ready on the DBA board.

Marostegui claimed this task.Apr 28 2021, 6:34 AM

@Ladsgroup can you confirm whether the second ALTER is meant to be for the image table and img_timestamp column? If it is for recentchanges table, that is being done at T276150

Marostegui moved this task from Ready to In progress on the DBA board.Apr 28 2021, 6:43 AM

Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.

Yes. you're right. Copy pasta error

Ladsgroup updated the task description. (Show Details)Apr 28 2021, 6:56 AM

\o/

Marostegui updated the task description. (Show Details)Apr 28 2021, 6:57 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-28T07:03:40Z] <marostegui> Deploy schema change on db2089:3316 and db1098:3316 T266486 T268392 T273360

Stashbot mentioned this in T266486: Schema change to turn user_last_timestamp.user_newtalk to binary(14).Apr 28 2021, 7:03 AM

Marostegui updated the task description. (Show Details)Apr 28 2021, 7:04 AM

Marostegui updated the task description. (Show Details)Apr 28 2021, 7:13 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-28T07:40:47Z] <marostegui> Deploy schema change on db1098:3316 and db1098:3316 T266486 T268392 T273360

@Ladsgroup this looks good?:

# mysql.py -hdb2089:3316 frwiki -e "show create table image\G"
*************************** 1. row ***************************
       Table: image
Create Table: CREATE TABLE `image` (
  `img_name` varbinary(255) NOT NULL DEFAULT '',
  `img_size` int(8) unsigned NOT NULL DEFAULT 0,
  `img_width` int(5) NOT NULL DEFAULT 0,
  `img_height` int(5) NOT NULL DEFAULT 0,
  `img_metadata` mediumblob NOT NULL,
  `img_bits` int(3) NOT NULL DEFAULT 0,
  `img_media_type` enum('UNKNOWN','BITMAP','DRAWING','AUDIO','VIDEO','MULTIMEDIA','OFFICE','TEXT','EXECUTABLE','ARCHIVE','3D') DEFAULT NULL,
  `img_major_mime` enum('unknown','application','audio','image','text','video','message','model','multipart') NOT NULL DEFAULT 'unknown',
  `img_minor_mime` varbinary(100) NOT NULL DEFAULT 'unknown',
  `img_description_id` bigint(20) unsigned NOT NULL,
  `img_actor` bigint(20) unsigned NOT NULL,
  `img_timestamp` binary(14) NOT NULL,
  `img_sha1` varbinary(32) NOT NULL DEFAULT '',
  PRIMARY KEY (`img_name`),
  KEY `img_size` (`img_size`),
  KEY `img_timestamp` (`img_timestamp`),
  KEY `img_media_mime` (`img_media_type`,`img_major_mime`,`img_minor_mime`),
  KEY `img_actor_timestamp` (`img_actor`,`img_timestamp`),
  KEY `img_sha1` (`img_sha1`(10))
) ENGINE=InnoDB DEFAULT CHARSET=binary ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=8

That field looks okay. Didn't check the whole table in depth (if any issues, it's a separate from this one and will show up in drift reports)

Mentioned in SAL (#wikimedia-operations) [2021-05-04T05:36:56Z] <marostegui> Deploy schema change on s6 codfw, lag will appear - T266486 T268392 T273360

Marostegui updated the task description. (Show Details)May 4 2021, 7:04 AM

s6 is done, pending the master. It will be finished once we've completed the migration to 10.4 on T280751

Marostegui updated the task description. (Show Details)May 5 2021, 1:57 PM

Marostegui updated the task description. (Show Details)May 5 2021, 2:05 PM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)May 6 2021, 5:58 AM

s5 is done, pending the master.

Marostegui updated the task description. (Show Details)May 7 2021, 6:15 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-07T06:17:28Z] <marostegui> Deploy schema change on s2 codfw, lag will appear T266486 T268392 T273360

Marostegui updated the task description. (Show Details)May 7 2021, 6:45 AM

Marostegui updated the task description. (Show Details)May 7 2021, 8:06 AM

s2 is done, pending the master.

Marostegui updated the task description. (Show Details)May 11 2021, 11:01 AM

Marostegui updated the task description. (Show Details)May 11 2021, 12:23 PM

Marostegui updated the task description. (Show Details)May 12 2021, 5:25 AM

Marostegui updated the task description. (Show Details)May 17 2021, 11:33 AM

Marostegui updated the task description. (Show Details)May 17 2021, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-17T11:55:23Z] <marostegui> Deploy schema change on s8 codfw, lag will appear in codfw T266486 T268392 T273360

Marostegui updated the task description. (Show Details)May 17 2021, 12:24 PM

Marostegui updated the task description. (Show Details)May 17 2021, 12:39 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-18T07:05:59Z] <marostegui> Deploy schema change on s4 codfw, lag will appear in codfw T266486 T268392 T273360

Marostegui updated the task description. (Show Details)May 19 2021, 5:50 AM

Marostegui updated the task description. (Show Details)May 19 2021, 7:00 AM

Marostegui updated the task description. (Show Details)May 19 2021, 7:30 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-19T07:31:44Z] <marostegui> Deploy schema change on s3 codfw, lag will appear in codfw T266486 T268392 T273360

Marostegui updated the task description. (Show Details)May 19 2021, 9:36 AM

Marostegui updated the task description. (Show Details)May 19 2021, 11:26 AM

Marostegui updated the task description. (Show Details)May 20 2021, 10:13 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-20T10:15:00Z] <marostegui> Deploy schema change on s1 codfw, lag will appear in codfw T266486 T268392 T273360

s3 is done, only the master pending, to be done once the switchover is completed (T283131)

Marostegui updated the task description. (Show Details)May 20 2021, 1:38 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-26T04:35:32Z] <marostegui> Deploy schema change on db1106, this will generate lag on s1 (enwiki) on wiki replicas T266486 T268392 T273360

s1 is fully done, only pending the master

Marostegui updated the task description. (Show Details)May 26 2021, 9:02 AM

Mentioned in SAL (#wikimedia-operations) [2021-06-03T05:20:04Z] <marostegui> Deploy schema change on db1121, lag will appear on s4 (commonswiki) wiki replicas - T266486 T268392 T273360