Hello, please try to reply using Reply tool to the comment by 31.30.171.119 here (originally posted here: https://cs.wikipedia.org/wiki/Wikipedie:N%C3%A1st%C4%9Bnka_spr%C3%A1vc%C5%AF#%C5%BD%C3%A1dost_o_polozamknut%C3%AD_%E2%80%93_[[4]]). Could you please fix that error?
Description
Details
Revisions and Commits
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | matmarex | T273413 Cannot reply to a comment with an external link in section title | |||
Resolved | matmarex | T274685 Comment IDs that reliably identify the comment across revisions/pages (comment names) |
Event Timeline
Hi, could you please describe what actually does happen? :) See https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks a lot. :)
Of course. I see this error message when I click at [ reply ] (instead of reply form):
It's because of the section heading – old parser and Parsoid generate different id attributes for it.
https://cs.wikipedia.org/wiki/Diskuse_s_wikipedistou:Patriccck/Test | id="Žádost_o_polozamknutí_–_[1]" |
https://cs.wikipedia.org/api/rest_v1/page/html/Diskuse_s_wikipedistou%3APatriccck%2FTest | id="Žádost_o_polozamknutí_–" |
@matmarex can you say more here? What specifically about the way the section heading has been written/formatted causes this result? E.g. it includes an external link?
...I ask the above in an attempt to estimate how common we assume this issue to occur.
Change 663906 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Introduce comment "names" to identify comments across revisions/pages
Change 663906 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Introduce comment "names" to identify comments across revisions/pages
@matmarex: I can't find any comment with an external link in section title on the page mentioned in the original report. So I added a section on my sandbox's discussion page on Beta cluster with an external link in the title, and I could reply to any comment under that section. But then it is also working on my production sandbox, so I am confused if I am checking the right thing. Clearer generic steps to reproduce this issue will be really helpful.
The section from the original bug report has been archived, I found it here: https://cs.wikipedia.org/wiki/Wikipedie:Nástěnka_správců/Archiv79#Žádost_o_polozamknutí_–_[[2]]
The first reply button in that section shows an error when clicked. It should open the reply tool when the patch is deployed next week.
wmf.37 was undeployed, see https://lists.wikimedia.org/pipermail/wikitech-l/2021-April/094406.html for the notice and T278343 for current status. We should re-check after it's deployed again.
@matmarex: I tested this before the wmf.37 rollback (I check the special:version page first before testing) and also, it's not working now either.
I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!
I think it would have worked if it wasn't for patch 7ad6328223579b6c1141aa3d0431dc6ea6edea30. I forgot we've made that change.
Change 677657 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Include comment names in 'transcludedfrom' API response
This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T273413
Change 677657 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Include comment names in 'transcludedfrom' API response