Page MenuHomePhabricator

Cannot reply to a comment with an external link in section title
Open, Needs TriagePublic

Description

Hello, please try to reply using Reply tool to the comment by 31.30.171.119 here (originally posted here: https://cs.wikipedia.org/wiki/Wikipedie:N%C3%A1st%C4%9Bnka_spr%C3%A1vc%C5%AF#%C5%BD%C3%A1dost_o_polozamknut%C3%AD_%E2%80%93_[[4]]). Could you please fix that error?

Event Timeline

Patriccck updated the task description. (Show Details)

Hi, could you please describe what actually does happen? :) See https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks a lot. :)

Of course. I see this error message when I click at [ reply ] (instead of reply form):

It's because of the section heading – old parser and Parsoid generate different id attributes for it.

It's because of the section heading – old parser and Parsoid generate different id attributes for it.

@matmarex can you say more here? What specifically about the way the section heading has been written/formatted causes this result? E.g. it includes an external link?

...I ask the above in an attempt to estimate how common we assume this issue to occur.

Yes, it's caused by the external link.

Change 663906 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Introduce comment "names" to identify comments across revisions/pages

https://gerrit.wikimedia.org/r/663906

It's because of the section heading – old parser and Parsoid generate different id attributes for it.

This sounds like something that should be fixed? cc @ssastry @cscott

matmarex renamed this task from Cannot reply to a comment to Cannot reply to a comment with an external link in section title.Feb 25 2021, 9:57 PM

Change 663906 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Introduce comment "names" to identify comments across revisions/pages

https://gerrit.wikimedia.org/r/663906

matmarex moved this task from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
matmarex added a project: Editing QA.

(accidentally closed due to Phabricator misfeature, re-opening for QA)

(accidentally closed due to Phabricator misfeature, re-opening for QA)

@matmarex: I can't find any comment with an external link in section title on the page mentioned in the original report. So I added a section on my sandbox's discussion page on Beta cluster with an external link in the title, and I could reply to any comment under that section. But then it is also working on my production sandbox, so I am confused if I am checking the right thing. Clearer generic steps to reproduce this issue will be really helpful.

The section from the original bug report has been archived, I found it here: https://cs.wikipedia.org/wiki/Wikipedie:Nástěnka_správců/Archiv79#Žádost_o_polozamknutí_–_[[2]]

The first reply button in that section shows an error when clicked. It should open the reply tool when the patch is deployed next week.


The section from the original bug report has been archived, I found it here: https://cs.wikipedia.org/wiki/Wikipedie:Nástěnka_správců/Archiv79#Žádost_o_polozamknutí_–_[[2]]

The first reply button in that section shows an error when clicked. It should open the reply tool when the patch is deployed next week.


okay..but it doesn't : (

wmf.37 was undeployed, see https://lists.wikimedia.org/pipermail/wikitech-l/2021-April/094406.html for the notice and T278343 for current status. We should re-check after it's deployed again.

wmf.37 was undeployed, see https://lists.wikimedia.org/pipermail/wikitech-l/2021-April/094406.html for the notice and T278343 for current status. We should re-check after it's deployed again.

@matmarex: I tested this before the wmf.37 rollback (I check the special:version page first before testing) and also, it's not working now either.

I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!

I think it would have worked if it wasn't for patch 7ad6328223579b6c1141aa3d0431dc6ea6edea30. I forgot we've made that change.

Change 677657 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Include comment names in 'transcludedfrom' API response

https://gerrit.wikimedia.org/r/677657

I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!

I think it would have worked if it wasn't for patch 7ad6328223579b6c1141aa3d0431dc6ea6edea30. I forgot we've made that change.

Hey! No worries, it's all good. Move it back to my column whenever it's fixed :)

This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T273413

Change 677657 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Include comment names in 'transcludedfrom' API response

https://gerrit.wikimedia.org/r/677657