Page MenuHomePhabricator

Card for already translated sentences disappear after starting with an empty sentence
Closed, ResolvedPublic

Description

Once the "starting with an empty sentence" option is used and applied, selecting previous sentences makes the bottom card to disappear.

Steps to reproduce:

  1. Start a translation of Moon (en->es) in the test instance
  2. Select the "Legal status" section and start the translation.
  3. Apply the proposed translation for the title and for the first sentence.
  4. On the second sentence switch to "Start with an empty sentence" using the "..." menu of the bottom card.
  5. Edit the translation to be "Test, test, test." and apply it.
  6. Select the previous translated sentences and observe how the bottom card disappears. Screenshots are provided below.

Expected result: the card for already translated sentences should be visible instead.

Next sentence shows the bottom card normally, but......when selecting the sentence previously added it disappearsThis also causes the initial sentence (not added as an empty sentence) to no longer show its card (which was visible before)
sx.wmflabs.org_index.php_Special_ContentTranslation_page=Moon&from=en&to=es&sx=true(iPhone 5_SE).png (640×1,136 px, 176 KB)
sx.wmflabs.org_index.php_Special_ContentTranslation_page=Moon&from=en&to=es&sx=true(iPhone 5_SE) (1).png (640×1,136 px, 236 KB)
sx.wmflabs.org_index.php_Special_ContentTranslation_page=Moon&from=en&to=es&sx=true(iPhone 5_SE) (2).png (640×1,136 px, 234 KB)

Event Timeline

Pginer-WMF raised the priority of this task from Medium to High.Feb 2 2021, 9:38 AM

Change 661911 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Fix TranslatedSegmentCard for empty translation MT option

https://gerrit.wikimedia.org/r/661911

Change 661911 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Fix TranslatedSegmentCard for empty translation MT option

https://gerrit.wikimedia.org/r/661911

the original issue looks solved but I've spotted another one:

once we edit the translation and then go back to it, the "edited by you" is at 100%.
if we keep going back on the sentences already translated with MT, it keeps showing 100% instead of 0%.
(video with the issue on the previous comment)

Is this to be solved here or a different ticket?
@Pginer-WMF

the original issue looks solved but I've spotted another one:

once we edit the translation and then go back to it, the "edited by you" is at 100%.
if we keep going back on the sentences already translated with MT, it keeps showing 100% instead of 0%.
(video with the issue on the previous comment)

Is this to be solved here or a different ticket?
@Pginer-WMF

From your comment it is not clear why you think it is wrong to show these sentences are 100% edited by you. My understanding of the scenario is that you used "Start with an empty sentence" so the starting point was an empty string, you wrote some contents completely from scratch and those contents are considered 100% coming from you. For example, in the video "asdasdas" has been modified completely form the initial text provided automatically (""). Does that make sense or am I misinterpreting something about the context here?

the original issue looks solved but I've spotted another one:

once we edit the translation and then go back to it, the "edited by you" is at 100%.
if we keep going back on the sentences already translated with MT, it keeps showing 100% instead of 0%.
(video with the issue on the previous comment)

Is this to be solved here or a different ticket?
@Pginer-WMF

From your comment it is not clear why you think it is wrong to show these sentences are 100% edited by you. My understanding of the scenario is that you used "Start with an empty sentence" so the starting point was an empty string, you wrote some contents completely from scratch and those contents are considered 100% coming from you. For example, in the video "asdasdas" has been modified completely form the initial text provided automatically (""). Does that make sense or am I misinterpreting something about the context here?

Sorry, bad explanation from my part.
in the video, the first two sentences are MT translated, only the third one ("asdasdas") is "Start with an empty sentence".

Thanks for the clarifications @Jpita. I created a separate ticket: T275124: Stats from previous sentences become wrong after starting one as an empty sentence
Feel free to add any missing details.