Page MenuHomePhabricator
Create Task
Maniphest T273447

Implement ADR-0016 for Secondary CI in Wikibase (Use Github Actions)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

T270158: [12h] Decide on the "secondary" CI for Wikibase code repository created an ADR, now we must implement the ADR for secondary CI in WIkibase.

Acceptance Criteria:

  • Wikibase secondary CI no longer uses travis
  • Wikibase secondary CI uses github actions
  • The same matrix of jobs is run with at least email notifications
  • No longer needed travis references are cleaned up in Wikibase.git

Details

SubjectRepoBranchLines +/-
Replace Travis CI badge with GitHub Actions badgemediawiki/extensions/Wikibasemaster+1 -1
Remove travis_branch from install.shmediawiki/extensions/Wikibasemaster+0 -3
Github Actions - add link to email notificationmediawiki/extensions/Wikibasemaster+7 -5
Github Actions CI - specify username and pass in mysql commandmediawiki/extensions/Wikibasemaster+3 -5
Github Actions CI - add mysqlnd extension to php setup stepmediawiki/extensions/Wikibasemaster+1 -1
Github Actions CI - add mysqli extension to php setup stepmediawiki/extensions/Wikibasemaster+1 -1
Github Actions - fix DB connection issues and separate actionsmediawiki/extensions/Wikibasemaster+43 -30
Wikibase: remove travis CI configurationmediawiki/extensions/Wikibasemaster+11 -61
Add scondary-ci job to existing github action on Wikibasemediawiki/extensions/Wikibasemaster+86 -1
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Feb 1 2021, 12:09 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 1 2021, 12:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Feb 1 2021, 12:09 PM
Addshore moved this task from Inbox to legacy-backlog on the [DEPRECATED] wdwb-tech board.Feb 2 2021, 10:09 AM
Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.
Addshore moved this task from Incoming to 1. Quick Wins (+I -E) on the [DEPRECATED] wdwb-tech (legacy-backlog) board.
Addshore updated the task description. (Show Details)Feb 3 2021, 12:50 PM
Addshore updated the task description. (Show Details)Feb 3 2021, 12:52 PM
darthmon_wmde updated the task description. (Show Details)Feb 3 2021, 12:53 PM
darthmon_wmde set the point value for this task to 8.
noarave moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Feb 3 2021, 1:37 PM
noarave edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from 1. Quick Wins (+I -E) to Active on the [DEPRECATED] wdwb-tech (legacy-backlog) board.Feb 3 2021, 1:59 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 3 2021, 2:15 PM
noarave claimed this task.Feb 15 2021, 9:36 AM
Restricted Application added a project: User-Noarave. · View Herald TranscriptFeb 15 2021, 9:36 AM
noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 15 2021, 9:36 AM
Addshore renamed this task from Implement ADR-0016 for Secondary CI in WIkibase (Use Github Actions) to Implement ADR-0016 for Secondary CI in Wikibase (Use Github Actions).Feb 23 2021, 1:48 PM
gerritbot added a comment.Feb 24 2021, 3:05 PM

Change 666647 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Add scondary-ci job to existing github action on Wikibase

https://gerrit.wikimedia.org/r/666647

gerritbot added a project: Patch-For-Review.Feb 24 2021, 3:05 PM
gerritbot added a comment.Feb 26 2021, 9:01 AM

Change 667111 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Merge remote-tracking branch 'origin/master' into T273447-implement-adr16-secondary-ci-github-actions

https://gerrit.wikimedia.org/r/667111

gerritbot added a comment.Feb 26 2021, 9:02 AM

Change 667111 abandoned by Noa wmde:
[mediawiki/extensions/Wikibase@master] Merge remote-tracking branch 'origin/master' into T273447-implement-adr16-secondary-ci-github-actions

Reason:

https://gerrit.wikimedia.org/r/667111

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 26 2021, 12:52 PM
gerritbot added a comment.Mar 2 2021, 9:55 AM

Change 666647 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add scondary-ci job to existing github action on Wikibase

https://gerrit.wikimedia.org/r/666647

gerritbot added a comment.Mar 2 2021, 11:33 AM

Change 667846 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Wikibase: remove travis CI configuration

https://gerrit.wikimedia.org/r/667846

gerritbot added a comment.Mar 3 2021, 8:19 AM

Change 667846 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wikibase: remove travis CI configuration

https://gerrit.wikimedia.org/r/667846

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 3 2021, 9:00 AM
Silvan_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 4 2021, 10:17 AM
gerritbot added a comment.Mar 4 2021, 2:12 PM

Change 668442 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Github Actions - fix DB connection issues and separate actions

https://gerrit.wikimedia.org/r/668442

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 4 2021, 2:14 PM
gerritbot added a comment.Mar 5 2021, 8:35 AM

Change 668442 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Github Actions - fix DB connection issues and separate actions

https://gerrit.wikimedia.org/r/668442

gerritbot added a comment.Mar 5 2021, 9:16 AM

Change 668653 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Github Actions CI - add mysqli extension to php setup step

https://gerrit.wikimedia.org/r/668653

gerritbot added a comment.Mar 5 2021, 10:32 AM

Change 668653 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Github Actions CI - add mysqli extension to php setup step

https://gerrit.wikimedia.org/r/668653

gerritbot added a comment.Mar 5 2021, 12:11 PM

Change 668677 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Github Actions CI - add mysqlnd extension to php setup step

https://gerrit.wikimedia.org/r/668677

gerritbot added a comment.Mar 5 2021, 12:52 PM

Change 668677 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Github Actions CI - add mysqlnd extension to php setup step

https://gerrit.wikimedia.org/r/668677

noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 5 2021, 12:58 PM
gerritbot added a comment.Mar 9 2021, 11:57 AM

Change 670149 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Github Actions CI - specify username and pass in mysql command

https://gerrit.wikimedia.org/r/670149

gerritbot added a comment.Mar 9 2021, 2:43 PM

Change 670149 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Github Actions CI - specify username and pass in mysql command

https://gerrit.wikimedia.org/r/670149

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 3:00 PM
gerritbot added a comment.Mar 10 2021, 8:45 AM

Change 670416 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Github Actions - add link to email notification

https://gerrit.wikimedia.org/r/670416

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 10 2021, 9:22 AM
gerritbot added a comment.Mar 11 2021, 3:36 PM

Change 670416 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Github Actions - add link to email notification

https://gerrit.wikimedia.org/r/670416

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 11 2021, 3:50 PM
Addshore moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 15 2021, 8:55 PM

I still see a couple of references to travis in a readme and in the scripts used for CI that probably need cleaning up one way or another.

image.png (161×648 px, 21 KB)

Right now we only run github secondary CI on master, which I think is likely fine
https://github.com/wikimedia/Wikibase/blob/master/.github/workflows/secondaryCI.yml#L4
Thus one of the referenced in the scripts checking the branch could likley be removed?

Addshore updated the task description. (Show Details)Mar 15 2021, 8:56 PM
• Tonina_Zhelyazkova_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 16 2021, 6:27 PM
gerritbot added a comment.Mar 16 2021, 6:27 PM

Change 672778 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] Replace Travis CI badge with GitHub Actions badge

https://gerrit.wikimedia.org/r/672778

gerritbot added a comment.Mar 16 2021, 6:33 PM

Change 672780 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] Replace travis_branch with git_branch in install.sh

https://gerrit.wikimedia.org/r/672780

• Tonina_Zhelyazkova_WMDE subscribed.Mar 16 2021, 6:36 PM
In T273447#6915665, @Addshore wrote:

Right now we only run github secondary CI on master, which I think is likely fine
https://github.com/wikimedia/Wikibase/blob/master/.github/workflows/secondaryCI.yml#L4
Thus one of the referenced in the scripts checking the branch could likley be removed?

I went ahead and replaced the Travis references with the branch name from the github environment variables.
LMK in the patch if it's better to remove it all together.

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 16 2021, 6:37 PM
gerritbot added a comment.Mar 17 2021, 5:26 PM

Change 672780 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove travis_branch from install.sh

https://gerrit.wikimedia.org/r/672780

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 17 2021, 6:00 PM
Addshore moved this task from legacy-backlog to Active on the [DEPRECATED] wdwb-tech board.Mar 18 2021, 9:29 AM
Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).
gerritbot added a comment.Mar 18 2021, 9:29 AM

Change 672778 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace Travis CI badge with GitHub Actions badge

https://gerrit.wikimedia.org/r/672778

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 18 2021, 9:43 AM
Addshore closed this task as Resolved.Mar 19 2021, 7:59 AM
Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 19 2021, 8:15 AM
Michael mentioned this in T295614: Migrate wdio-wikibase from using Travis-CI to Github Actions.Nov 12 2021, 6:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL