Page MenuHomePhabricator
Create Task
Maniphest T273493

Add a startIcon option to buttons too
Closed, DeclinedPublic
Actions

Description

Offered in the input component already
Needed for: progress towards feature parity with OOUI (specifically for T259216: Migrate Special:GlobalWatchlist to Vue where the OOUI buttons have icons and the vue ones should too)

Related Objects

Event Timeline

DannyS712 created this task.Feb 1 2021, 5:18 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 1 2021, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Others on the User-DannyS712 board.Feb 1 2021, 5:18 PM
DannyS712 mentioned this in T259216: Migrate Special:GlobalWatchlist to Vue.
Catrope subscribed.May 11 2021, 12:00 AM

FYI you can already do this without a startIcon prop, because a button (unlike an input) can contain arbitrary content:

<wvui-button>
    <wvui-icon :icon="someIcon" />
    Some text
</wvui-button>

We're discussing whether to keep doing it this way or use a different approach at T278509: Add Button component to Codex

Volker_E closed this task as Declined.Sep 9 2022, 8:30 PM
Volker_E subscribed.

As @roan mentioned that was possible by adding icons, also in successor toolkit Codex.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits