Page MenuHomePhabricator

Make config change to enable Reply Tool A/B test
Open, HighPublic

Description

This task is about enabling/turning on the Reply Tool A/B test at the 22 21 ===Participating wikis (listed below) where the A/B has NOT yet been deployed.[i]

Deployment timing

We would like for the A/B test to be made available at the ===Participating wikis on THURSDAY, 11-FEBRUARY-2021.

Deployment timing is back to "TBD" considering the A/B test should not be made available until after wmf/1.36.0-wmf.29 reaches all Wikipedias. See: T271343.

Participating wikis

NumberWikiCodeStatus
1.French Wikipediafrwiki
2.Spanish Wikipediaeswiki
3.Italian Wikipediaitwiki
4.Japanese Wikipediajawiki
5.Persian Wikipediafawiki
6.Polish Wikipediaplwiki
7.Hebrew Wikipediahewiki
8.Dutch Wikipedianlwiki
9.Hindi Wikipediahiwiki
10.Korean Wikipediakowiki
11.Vietnamese Wikipediaviwiki
12.Thai Wikipediathwiki
13.Portuguese Wikipediaptwiki
14.Bengali Wikipediabnwiki
15.Egyptian Wikipediaarzwiki
16.Swahili Wikipediaswwiki
17.Chinese Wikipediazhwiki
18.Ukrainian Wikipediaukwiki
19.Indonesia WikipediaidwikiEnabled in T268191#6767541
20.Amharic Wikipediaamwiki
21.Oromo Wikipediaomwiki
22.Afrikaans Wikipediaafwiki

Testing instructions

  1. At even-numbered Wikipedias listed in the Participating wikis section above, do the following:
  2. Post a test comment using the Reply Tool (source or visual mode is fine) to a page of your choosing (e.g. your Sandbox talk page) and verify the comment is being posted to the page as you expect it to.
  3. Visit a random talk page and verify [ reply ] links are appearing as you expect them to
  4. Click a [ reply ] link and verify the Reply Tool opens as you expect it to.
  5. Document (e.g. file a ticket and/or comment here if you notice any unexpected behavior as part of completing steps "2, 3 and 4.)

Done

  • @ppelberg to comment on T273406 once the ===Deployment timing has been set
  • The Reply Tool A/B test is made available at the ===Participating wikis on the date specified in the === Deployment timing section

i. The A/B test was enabled at id.wiki in T268191#6767541.

Event Timeline

ppelberg created this task.Mon, Feb 1, 11:05 PM
Restricted Application added subscribers: Huji, Cosine02, Base, revi. · View Herald TranscriptMon, Feb 1, 11:05 PM
ppelberg renamed this task from Make config change to enabled Reply Tool A/B test to Make config change to enable Reply Tool A/B test .Mon, Feb 1, 11:23 PM
ppelberg added a subscriber: DLynch.

Deployment timing

Per the conversation @DLynch, @MNeisler and I had in chat today, we would like for the A/B test to begin this Thursday, 4-February-2021.

I've updated the task description to reflect the above.

ppelberg triaged this task as High priority.Mon, Feb 1, 11:31 PM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)Mon, Feb 1, 11:34 PM
Shizhao moved this task from Backlog to Research on the Chinese-Sites board.

Deployment timing update
Per today's standup, the A/B test should NOT be enabled until after wmf/1.36.0-wmf.29 reaches all Wikipedias.

As of 21:35 today, 2-Feb-2021, wmf/1.36.0-wmf.29 remains blocked. More details in T271343.

I've updated the task description to reflect this.

ppelberg updated the task description. (Show Details)Tue, Feb 2, 9:38 PM

Change 661373 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Enable DiscussionTools Reply Tool A/B test

https://gerrit.wikimedia.org/r/661373

Deployment timing update
Per today's standup, the A/B test should NOT be enabled until after wmf/1.36.0-wmf.29 reaches all Wikipedias.

As of 21:35 today, 2-Feb-2021, wmf/1.36.0-wmf.29 remains blocked. More details in T271343.

Looks like this will have to wait until next week.

ppelberg added a comment.EditedMon, Feb 8, 7:02 PM

Next steps

  • As discussed during today's team standup, @DLynch is investigating what would be involved with backporting all of the necessary patches to start the A/B test without needing to depend on the train running, which is currently blocked (see: T271343).
DLynch added a comment.Mon, Feb 8, 7:41 PM

In a backport window we would need to put:

  1. The config patch Bartosz wrote above
  2. The logging patch for VisualEditor for DT buckets
  3. The logging patch for WikiEditor for DT buckets

They're pretty easy to cherry-pick onto the current state of the branch.

In fact, the only likely conflicts are with these, which are not part of this... but if we get into anything for the new discussions feature we'd probably also want, related to T272544:

  1. The logging patch for VisualEditor for proper new-section tracking
  2. The logging patch for WikiEditor for proper new-section tracking
  3. The schema-bump patch to WikimediaEvents to support the previous patches

Deployment timing
The deployment is scheduled for today, 9-Feb-2021, at 4pm PST / 12am UTC on 10-Feb-2021.

cc @Whatamidoing-WMF

ppelberg updated the task description. (Show Details)Tue, Feb 9, 10:31 PM
ppelberg updated the task description. (Show Details)

Deployment timing
The deployment is scheduled for today, 9-Feb-2021, at 4pm PST / 12am UTC on 10-Feb-2021.

cc @Whatamidoing-WMF

This deployment was blocked and accordingly, did not happen. We'll revisit this tomorrow (10-February).

Next steps

  • Today:
    • Do nothing and observe whether 1.36.0-wmf.30 is rolled out to Group 1
  • Tomorrow:

Next steps

Considering 1.36.0-wmf.30 has been rolled out to Group 1 [i], we're going to move forward with the following: deploy https://gerrit.wikimedia.org/r/661373 during today's, 4pm PST / 00:00 UTC backport window. [ii]


i. https://versions.toolforge.org/
ii. https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210211T2200

ppelberg updated the task description. (Show Details)Thu, Feb 11, 6:55 PM

Change 661373 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable DiscussionTools Reply Tool A/B test

https://gerrit.wikimedia.org/r/661373

Mentioned in SAL (#wikimedia-operations) [2021-02-12T01:04:12Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 389f7f1fdc9ad4a0c163ccfe1d80f2aaec7f8038: Enable DiscussionTools Reply Tool A/B test (T273554) (duration: 01m 08s)

ppelberg added a project: Editing QA.
ppelberg moved this task from Inbox to High Priority on the Editing QA board.
ppelberg updated the task description. (Show Details)Thu, Feb 25, 8:19 PM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)Thu, Feb 25, 8:22 PM