Page MenuHomePhabricator
Create Task
Maniphest T273570

Make ComposerJson check that composer-merge-plugin changes are satisfied
Open, Needs TriagePublic
Actions

Description

Following on from my comments at https://github.com/wikimedia/composer-merge-plugin/pull/189#issuecomment-771280032... And therefore related to T248908: composer-merge-plugin support for composer 2.0

ComposerJson::getRequiredDependencies only gets the "require" items from the root composer.json... We don't do anything to make sure the requires of files included in composer.local.json via the composer merge-plugin are actually installed/resolved...

composer-merge-plugin is in requires itself... Can we make MW call code to check things are all resolved nicely?

It would seem useful for the edge cases of the plugin and composer upgrades in one go... And also when someone adds something to composer.local.json, but then never run composer update... It's certainly possible their wiki may break from not having had an extensions composer requirements resolved and installed...

Related Objects

Event Timeline

Reedy created this task.Feb 2 2021, 1:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2021, 1:35 AM
Reedy renamed this task from Make ComposerJson resolve composer-merge-plugin additions are satisfied to Make ComposerJson check that composer-merge-plugin changes are satisfied.Feb 2 2021, 1:46 AM
Reedy updated the task description. (Show Details)Feb 2 2021, 1:57 AM
Reedy added a comment.EditedFeb 2 2021, 2:01 AM

I guess this is kind of a dupe of T119711: Let update.php check for composer updates in extensions... Though that sounds to be potentially for cases where composer has been run in an extensions directory and therefore depending on load_composer_autoloader

Reedy moved this task from Backlog to Features/Improvements on the Composer board.Feb 2 2021, 2:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL