Page MenuHomePhabricator

MediaWiki.Usage.DirUsageSniff false negative
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

mkdir /tmp/test
cd /tmp/test
cat <<EOF > test.php
<?php
require dirname( __FILE__ ) . '/bar.php';
EOF
composer require mediawiki/mediawiki-codesniffer
vendor/bin/phpcs --standard=vendor/mediawiki/mediawiki-codesniffer/MediaWiki/ruleset.xml test.php

Actual Results:

phpcs reports no errors or warnings.

Expected Results:

FILE: /tmp/test/test.php
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 2 | ERROR | [x] Use __DIR__ constant instead of calling dirname(__FILE__)
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

Notes:

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/647205

Event Timeline

Change 661250 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] DirUsageSniff: check strings outside of classes

https://gerrit.wikimedia.org/r/661250

Change 661250 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] DirUsageSniff: check strings outside of classes

https://gerrit.wikimedia.org/r/661250

DannyS712 claimed this task.